Skip to content

Commit cf08d6f

Browse files
chuckleveramschuma-ntap
authored andcommitted
SUNRPC: task_run_action should display tk_callback
This shows up in every RPC: kworker/4:1-19772 [004] 3467.373443: rpc_task_run_action: task:4711@2 flags=0e81 state=0005 status=0 action=call_status kworker/4:1-19772 [004] 3467.373444: rpc_task_run_action: task:4711@2 flags=0e81 state=0005 status=0 action=call_status What's actually going on is that the first iteration of the RPC scheduler is invoking the function in tk_callback (in this case, xprt_timer), then invoking call_status on the next iteration. Feeding do_action, rather than tk_action, to the "task_run_action" trace point will now always display the correct FSM step. Signed-off-by: Chuck Lever <[email protected]> Signed-off-by: Anna Schumaker <[email protected]>
1 parent 5206944 commit cf08d6f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/sunrpc/sched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ static void __rpc_execute(struct rpc_task *task)
770770
if (do_action == NULL)
771771
break;
772772
}
773-
trace_rpc_task_run_action(task->tk_client, task, task->tk_action);
773+
trace_rpc_task_run_action(task->tk_client, task, do_action);
774774
do_action(task);
775775

776776
/*

0 commit comments

Comments
 (0)