Skip to content

Commit cf8f9aa

Browse files
llandwerlin-inteljnikula
authored andcommitted
drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
The same tests failing on CFL+ platforms are also failing on ICL. Documentation doesn't list the WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but applying it fixes the same tests as CFL. v2: Use only one whitelist entry (Lionel) Signed-off-by: Lionel Landwerlin <[email protected]> Tested-by: Anuj Phogat <[email protected]> Cc: [email protected] # 6883eab27481: drm/i915: Support flags in whitlist WAs Cc: [email protected] Acked-by: Chris Wilson <[email protected]> Signed-off-by: Chris Wilson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 3fe0107) Signed-off-by: Jani Nikula <[email protected]>
1 parent 6ce5bfe commit cf8f9aa

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,6 +1144,19 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
11441144

11451145
/* WaEnableStateCacheRedirectToCS:icl */
11461146
whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1147+
1148+
/*
1149+
* WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
1150+
*
1151+
* This covers 4 register which are next to one another :
1152+
* - PS_INVOCATION_COUNT
1153+
* - PS_INVOCATION_COUNT_UDW
1154+
* - PS_DEPTH_COUNT
1155+
* - PS_DEPTH_COUNT_UDW
1156+
*/
1157+
whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1158+
RING_FORCE_TO_NONPRIV_RD |
1159+
RING_FORCE_TO_NONPRIV_RANGE_4);
11471160
break;
11481161

11491162
case VIDEO_DECODE_CLASS:

0 commit comments

Comments
 (0)