Skip to content

Commit cfa0ebc

Browse files
Andrew Jonesmstsirkin
authored andcommitted
virtio-net: fix module unloading
Unregister the driver before removing multi-instance hotplug callbacks. This order avoids the warning issued from __cpuhp_remove_state_cpuslocked when the number of remaining instances isn't yet zero. Fixes: 8017c27 ("net/virtio-net: Convert to hotplug state machine") Cc: Sebastian Andrzej Siewior <[email protected]> Signed-off-by: Andrew Jones <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent f9aada5 commit cfa0ebc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/virtio_net.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2743,9 +2743,9 @@ module_init(virtio_net_driver_init);
27432743

27442744
static __exit void virtio_net_driver_exit(void)
27452745
{
2746+
unregister_virtio_driver(&virtio_net_driver);
27462747
cpuhp_remove_multi_state(CPUHP_VIRT_NET_DEAD);
27472748
cpuhp_remove_multi_state(virtionet_online);
2748-
unregister_virtio_driver(&virtio_net_driver);
27492749
}
27502750
module_exit(virtio_net_driver_exit);
27512751

0 commit comments

Comments
 (0)