Skip to content

Commit cfc30ad

Browse files
gal-pressmanjgunthorpe
authored andcommitted
IB/usnic: Remove stub functions
Lack of mandatory verbs no longer fail device registration, the device will be marked as a non-kverbs provider. Signed-off-by: Gal Pressman <[email protected]> Tested-by: Parvi Kaustubhi <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 6780c4f commit cfc30ad

File tree

3 files changed

+0
-75
lines changed

3 files changed

+0
-75
lines changed

drivers/infiniband/hw/usnic/usnic_ib_main.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -333,32 +333,25 @@ static void usnic_get_dev_fw_str(struct ib_device *device, char *str)
333333
static const struct ib_device_ops usnic_dev_ops = {
334334
.alloc_pd = usnic_ib_alloc_pd,
335335
.alloc_ucontext = usnic_ib_alloc_ucontext,
336-
.create_ah = usnic_ib_create_ah,
337336
.create_cq = usnic_ib_create_cq,
338337
.create_qp = usnic_ib_create_qp,
339338
.dealloc_pd = usnic_ib_dealloc_pd,
340339
.dealloc_ucontext = usnic_ib_dealloc_ucontext,
341340
.dereg_mr = usnic_ib_dereg_mr,
342-
.destroy_ah = usnic_ib_destroy_ah,
343341
.destroy_cq = usnic_ib_destroy_cq,
344342
.destroy_qp = usnic_ib_destroy_qp,
345343
.get_dev_fw_str = usnic_get_dev_fw_str,
346-
.get_dma_mr = usnic_ib_get_dma_mr,
347344
.get_link_layer = usnic_ib_port_link_layer,
348345
.get_netdev = usnic_get_netdev,
349346
.get_port_immutable = usnic_port_immutable,
350347
.mmap = usnic_ib_mmap,
351348
.modify_qp = usnic_ib_modify_qp,
352-
.poll_cq = usnic_ib_poll_cq,
353-
.post_recv = usnic_ib_post_recv,
354-
.post_send = usnic_ib_post_send,
355349
.query_device = usnic_ib_query_device,
356350
.query_gid = usnic_ib_query_gid,
357351
.query_pkey = usnic_ib_query_pkey,
358352
.query_port = usnic_ib_query_port,
359353
.query_qp = usnic_ib_query_qp,
360354
.reg_user_mr = usnic_ib_reg_mr,
361-
.req_notify_cq = usnic_ib_req_notify_cq,
362355
};
363356

364357
/* Start of PF discovery section */

drivers/infiniband/hw/usnic/usnic_ib_verbs.c

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -760,57 +760,4 @@ int usnic_ib_mmap(struct ib_ucontext *context,
760760
return -EINVAL;
761761
}
762762

763-
/* In ib callbacks section - Start of stub funcs */
764-
struct ib_ah *usnic_ib_create_ah(struct ib_pd *pd,
765-
struct rdma_ah_attr *ah_attr,
766-
u32 flags,
767-
struct ib_udata *udata)
768-
769-
{
770-
usnic_dbg("\n");
771-
return ERR_PTR(-EPERM);
772-
}
773-
774-
int usnic_ib_destroy_ah(struct ib_ah *ah, u32 flags)
775-
{
776-
usnic_dbg("\n");
777-
return -EINVAL;
778-
}
779-
780-
int usnic_ib_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
781-
const struct ib_send_wr **bad_wr)
782-
{
783-
usnic_dbg("\n");
784-
return -EINVAL;
785-
}
786-
787-
int usnic_ib_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr,
788-
const struct ib_recv_wr **bad_wr)
789-
{
790-
usnic_dbg("\n");
791-
return -EINVAL;
792-
}
793-
794-
int usnic_ib_poll_cq(struct ib_cq *ibcq, int num_entries,
795-
struct ib_wc *wc)
796-
{
797-
usnic_dbg("\n");
798-
return -EINVAL;
799-
}
800-
801-
int usnic_ib_req_notify_cq(struct ib_cq *cq,
802-
enum ib_cq_notify_flags flags)
803-
{
804-
usnic_dbg("\n");
805-
return -EINVAL;
806-
}
807-
808-
struct ib_mr *usnic_ib_get_dma_mr(struct ib_pd *pd, int acc)
809-
{
810-
usnic_dbg("\n");
811-
return ERR_PTR(-ENOMEM);
812-
}
813-
814-
815-
/* In ib callbacks section - End of stub funcs */
816763
/* End of ib callbacks section */

drivers/infiniband/hw/usnic/usnic_ib_verbs.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,4 @@ struct ib_ucontext *usnic_ib_alloc_ucontext(struct ib_device *ibdev,
7575
int usnic_ib_dealloc_ucontext(struct ib_ucontext *ibcontext);
7676
int usnic_ib_mmap(struct ib_ucontext *context,
7777
struct vm_area_struct *vma);
78-
struct ib_ah *usnic_ib_create_ah(struct ib_pd *pd,
79-
struct rdma_ah_attr *ah_attr,
80-
u32 flags,
81-
struct ib_udata *udata);
82-
83-
int usnic_ib_destroy_ah(struct ib_ah *ah, u32 flags);
84-
int usnic_ib_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
85-
const struct ib_send_wr **bad_wr);
86-
int usnic_ib_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr,
87-
const struct ib_recv_wr **bad_wr);
88-
int usnic_ib_poll_cq(struct ib_cq *ibcq, int num_entries,
89-
struct ib_wc *wc);
90-
int usnic_ib_req_notify_cq(struct ib_cq *cq,
91-
enum ib_cq_notify_flags flags);
92-
struct ib_mr *usnic_ib_get_dma_mr(struct ib_pd *pd, int acc);
9378
#endif /* !USNIC_IB_VERBS_H */

0 commit comments

Comments
 (0)