Skip to content

Commit d034071

Browse files
kvaloKalle Valo
authored andcommitted
wifi: ath10k: fix QCOM_SMEM dependency
Nathan noticed that when HWSPINLOCK is disabled there's a Kconfig warning: WARNING: unmet direct dependencies detected for QCOM_SMEM Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n] Selected by [m]: - ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) The problem here is that QCOM_SMEM depends on HWSPINLOCK so we cannot select QCOM_SMEM and instead we neeed to use 'depends on'. Reported-by: Nathan Chancellor <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Fixes: 4d79f6f ("wifi: ath10k: Store WLAN firmware version in SMEM image table") Signed-off-by: Kalle Valo <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent e9ab0b2 commit d034071

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/ath/ath10k

1 file changed

+1
-1
lines changed

drivers/net/wireless/ath/ath10k/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ config ATH10K_SNOC
4444
tristate "Qualcomm ath10k SNOC support"
4545
depends on ATH10K
4646
depends on ARCH_QCOM || COMPILE_TEST
47-
select QCOM_SMEM
47+
depends on QCOM_SMEM
4848
select QCOM_SCM
4949
select QCOM_QMI_HELPERS
5050
help

0 commit comments

Comments
 (0)