Skip to content

Commit d12d42f

Browse files
committed
i2c/of: Allow device node to be passed via i2c_board_info
The struct device_node *of_node pointer is moving out of dev->archdata and into the struct device proper. of_i2c.c needs to set the of_node pointer before the device is registered. Since the i2c subsystem doesn't allow 2 stage allocation and registration of i2c devices, the of_node pointer needs to be passed via the i2c_board_info structure so that it is set prior to registration. This patch adds of_node to struct i2c_board_info (conditional on CONFIG_OF), sets of_node in i2c_new_device(), and modifies of_i2c.c to use the new parameter. The calling of dev_archdata_set_node() from of_i2c will be removed in a subsequent patch when of_node is removed from archdata and all users are converted over. Signed-off-by: Grant Likely <[email protected]>
1 parent d706c1b commit d12d42f

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

drivers/i2c/i2c-core.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,9 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
387387
client->dev.parent = &client->adapter->dev;
388388
client->dev.bus = &i2c_bus_type;
389389
client->dev.type = &i2c_client_type;
390+
#ifdef CONFIG_OF
391+
client->dev.of_node = info->of_node;
392+
#endif
390393

391394
dev_set_name(&client->dev, "%d-%04x", i2c_adapter_id(adap),
392395
client->addr);

drivers/of/of_i2c.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
4343
info.addr = be32_to_cpup(addr);
4444

4545
dev_archdata_set_node(&dev_ad, node);
46+
info.of_node = node;
4647
info.archdata = &dev_ad;
4748

4849
request_module("%s", info.type);

include/linux/i2c.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
#include <linux/device.h> /* for struct device */
3535
#include <linux/sched.h> /* for completion */
3636
#include <linux/mutex.h>
37+
#include <linux/of.h> /* for struct device_node */
3738

3839
extern struct bus_type i2c_bus_type;
3940

@@ -251,6 +252,9 @@ struct i2c_board_info {
251252
unsigned short addr;
252253
void *platform_data;
253254
struct dev_archdata *archdata;
255+
#ifdef CONFIG_OF
256+
struct device_node *of_node;
257+
#endif
254258
int irq;
255259
};
256260

0 commit comments

Comments
 (0)