Skip to content

Commit d1d0589

Browse files
Bjarke Istrup PedersenH. Peter Anvin
authored andcommitted
arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
It seems that there was an error with the active_low = 1 for the LED, since it should be set to 0 (meaning that active is high, since 0 is false, hence the confusion. The wiki article about it confuses it, since it contradicts itself, regarding what turns on the LED. I have tested 3.4-rc2 on my net5501 with this patch, and it makes the LED behave correctly, where "none" turns it off, and "default-on" turns it on, when echoed onto the trigger "file" in /sys/class/leds. Signed-off-by: Bjarke Istrup Pedersen <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Cc: Philip Prindeville <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: H. Peter Anvin <[email protected]>
1 parent 7c77cda commit d1d0589

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/platform/geode/net5501.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
6363
.name = "net5501:1",
6464
.gpio = 6,
6565
.default_trigger = "default-on",
66-
.active_low = 1,
66+
.active_low = 0,
6767
},
6868
};
6969

0 commit comments

Comments
 (0)