xen: netback: remove redundant xenvif_put

Andrew Jones · davem330 · commit d37204566a61 · 2013-02-19T00:51:09.000-05:00
netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
a xenvif_put(). As callers of netbk_fatal_tx_err should only
have one reference to the vif at this time, then the xenvif_put
in netbk_fatal_tx_err is one too many.

Signed-off-by: Andrew Jones &lt;drjones@redhat.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
@@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
 {
 	netdev_err(vif->dev, "fatal error; disabling device\n");
 	xenvif_carrier_off(vif);
-	xenvif_put(vif);
 }
 
 static int netbk_count_requests(struct xenvif *vif,

Original file line number	Diff line number	Diff line change
`@@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)`
`893`	`893`	`{`
`894`	`894`	`netdev_err(vif->dev, "fatal error; disabling device\n");`
`895`	`895`	`xenvif_carrier_off(vif);`
`896`		`- xenvif_put(vif);`
`897`	`896`	`}`
`898`	`897`
`899`	`898`	`static int netbk_count_requests(struct xenvif *vif,`