Skip to content

Commit d38c4ae

Browse files
JeffyCNbroonie
authored andcommitted
spi: rockchip: Fix clock handling in suspend/resume
The runtime suspend callback might be called by pm domain framework at suspend_noirq stage. It would try to disable the clocks which already been disabled by rockchip_spi_suspend. Call pm_runtime_force_suspend/pm_runtime_force_resume when suspend/resume to avoid that. Signed-off-by: Jeffy Chen <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent 6a06e89 commit d38c4ae

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

drivers/spi/spi-rockchip.c

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -846,10 +846,9 @@ static int rockchip_spi_suspend(struct device *dev)
846846
if (ret < 0)
847847
return ret;
848848

849-
if (!pm_runtime_suspended(dev)) {
850-
clk_disable_unprepare(rs->spiclk);
851-
clk_disable_unprepare(rs->apb_pclk);
852-
}
849+
ret = pm_runtime_force_suspend(dev);
850+
if (ret < 0)
851+
return ret;
853852

854853
pinctrl_pm_select_sleep_state(dev);
855854

@@ -864,17 +863,9 @@ static int rockchip_spi_resume(struct device *dev)
864863

865864
pinctrl_pm_select_default_state(dev);
866865

867-
if (!pm_runtime_suspended(dev)) {
868-
ret = clk_prepare_enable(rs->apb_pclk);
869-
if (ret < 0)
870-
return ret;
871-
872-
ret = clk_prepare_enable(rs->spiclk);
873-
if (ret < 0) {
874-
clk_disable_unprepare(rs->apb_pclk);
875-
return ret;
876-
}
877-
}
866+
ret = pm_runtime_force_resume(dev);
867+
if (ret < 0)
868+
return ret;
878869

879870
ret = spi_master_resume(rs->master);
880871
if (ret < 0) {

0 commit comments

Comments
 (0)