USB: serial: metro-usb: drop redundant URB unlink

jhovold · jhovold · commit d395c9ab0090 · 2017-02-08T19:27:52.000+01:00
Drop redundant URB unlink as there's no need to unlink an URB which is
about to be killed synchronously.

Reviewed-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
Signed-off-by: Johan Hovold &lt;johan@kernel.org&gt;
diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
@@ -165,7 +165,6 @@ static void metrousb_cleanup(struct usb_serial_port *port)
 {
 	dev_dbg(&port->dev, "%s\n", __func__);
 
-	usb_unlink_urb(port->interrupt_in_urb);
 	usb_kill_urb(port->interrupt_in_urb);
 
 	metrousb_send_unidirectional_cmd(UNI_CMD_CLOSE, port);

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,6 @@ static void metrousb_cleanup(struct usb_serial_port *port)`
`165`	`165`	`{`
`166`	`166`	`dev_dbg(&port->dev, "%s\n", __func__);`
`167`	`167`
`168`		`- usb_unlink_urb(port->interrupt_in_urb);`
`169`	`168`	`usb_kill_urb(port->interrupt_in_urb);`
`170`	`169`
`171`	`170`	`metrousb_send_unidirectional_cmd(UNI_CMD_CLOSE, port);`