Skip to content

Commit d3a9b0c

Browse files
ChaitanayaKulkarnikeithbusch
authored andcommitted
nvmet: check sscanf value for subsys serial attr
For nvmet in configfs.c we check return values for all the sscanf() calls. Add similar check into the nvmet_subsys_attr_serial_store(). Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]> Signed-off-by: Chaitanya Kulkarni <[email protected]> Signed-off-by: Keith Busch <[email protected]>
1 parent 013b7eb commit d3a9b0c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/nvme/target/configfs.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -849,10 +849,13 @@ static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item,
849849
static ssize_t nvmet_subsys_attr_serial_store(struct config_item *item,
850850
const char *page, size_t count)
851851
{
852-
struct nvmet_subsys *subsys = to_subsys(item);
852+
u64 serial;
853+
854+
if (sscanf(page, "%llx\n", &serial) != 1)
855+
return -EINVAL;
853856

854857
down_write(&nvmet_config_sem);
855-
sscanf(page, "%llx\n", &subsys->serial);
858+
to_subsys(item)->serial = serial;
856859
up_write(&nvmet_config_sem);
857860

858861
return count;

0 commit comments

Comments
 (0)