Skip to content

Commit d454a27

Browse files
Liu Xiangtytso
authored andcommitted
ext4: fix prefetchw of NULL page
In ext4_mpage_readpages(), if the parameter pages is not NULL, another parameter page is NULL. At the first time prefetchw(&page->flags) works on NULL. From second time, prefetchw(&page->flags) always works on the last consumed page. This might do little improvment for handling current page. So prefetchw() should be called while the page pointer has just been updated. Signed-off-by: Liu Xiang <[email protected]> Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 742b06b commit d454a27

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

fs/ext4/readpage.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,10 @@ int ext4_mpage_readpages(struct address_space *mapping,
127127
int fully_mapped = 1;
128128
unsigned first_hole = blocks_per_page;
129129

130-
prefetchw(&page->flags);
131130
if (pages) {
132131
page = lru_to_page(pages);
132+
133+
prefetchw(&page->flags);
133134
list_del(&page->lru);
134135
if (add_to_page_cache_lru(page, mapping, page->index,
135136
readahead_gfp_mask(mapping)))

0 commit comments

Comments
 (0)