Skip to content

Commit d5a3c15

Browse files
author
Steve French
committed
SMB3: clarify some of the unused CreateOption flags
Update comments to show flags which should be not set (zero). See MS-SMB2 section 2.2.13 Signed-off-by: Steve French <[email protected]>
1 parent 1460720 commit d5a3c15

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

fs/smb/common/smb2pdu.h

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1097,16 +1097,23 @@ struct smb2_change_notify_rsp {
10971097
#define FILE_WRITE_THROUGH_LE cpu_to_le32(0x00000002)
10981098
#define FILE_SEQUENTIAL_ONLY_LE cpu_to_le32(0x00000004)
10991099
#define FILE_NO_INTERMEDIATE_BUFFERING_LE cpu_to_le32(0x00000008)
1100+
/* FILE_SYNCHRONOUS_IO_ALERT_LE cpu_to_le32(0x00000010) should be zero, ignored */
1101+
/* FILE_SYNCHRONOUS_IO_NONALERT cpu_to_le32(0x00000020) should be zero, ignored */
11001102
#define FILE_NON_DIRECTORY_FILE_LE cpu_to_le32(0x00000040)
11011103
#define FILE_COMPLETE_IF_OPLOCKED_LE cpu_to_le32(0x00000100)
11021104
#define FILE_NO_EA_KNOWLEDGE_LE cpu_to_le32(0x00000200)
1105+
/* FILE_OPEN_REMOTE_INSTANCE cpu_to_le32(0x00000400) should be zero, ignored */
11031106
#define FILE_RANDOM_ACCESS_LE cpu_to_le32(0x00000800)
1104-
#define FILE_DELETE_ON_CLOSE_LE cpu_to_le32(0x00001000)
1107+
#define FILE_DELETE_ON_CLOSE_LE cpu_to_le32(0x00001000) /* MBZ */
11051108
#define FILE_OPEN_BY_FILE_ID_LE cpu_to_le32(0x00002000)
11061109
#define FILE_OPEN_FOR_BACKUP_INTENT_LE cpu_to_le32(0x00004000)
11071110
#define FILE_NO_COMPRESSION_LE cpu_to_le32(0x00008000)
1111+
/* FILE_OPEN_REQUIRING_OPLOCK cpu_to_le32(0x00010000) should be zero, ignored */
1112+
/* FILE_DISALLOW_EXCLUSIVE cpu_to_le32(0x00020000) should be zero, ignored */
1113+
/* FILE_RESERVE_OPFILTER cpu_to_le32(0x00100000) MBZ */
11081114
#define FILE_OPEN_REPARSE_POINT_LE cpu_to_le32(0x00200000)
11091115
#define FILE_OPEN_NO_RECALL_LE cpu_to_le32(0x00400000)
1116+
/* #define FILE_OPEN_FOR_FREE_SPACE_QUERY cpu_to_le32(0x00800000) should be zero, ignored */
11101117
#define CREATE_OPTIONS_MASK_LE cpu_to_le32(0x00FFFFFF)
11111118

11121119
#define FILE_READ_RIGHTS_LE (FILE_READ_DATA_LE | FILE_READ_EA_LE \

0 commit comments

Comments
 (0)