Skip to content

Commit d5a972f

Browse files
can: mcp251xfd: mcp251xfd_stop(): add missing hrtimer_cancel()
In commit 169d00a ("can: mcp251xfd: add TX IRQ coalescing support") software based TX coalescing was added to the driver. The key idea is to keep the TX complete IRQ disabled for some time after processing it and re-enable later by a hrtimer. When bringing the interface down, this timer has to be stopped. Add the missing hrtimer_cancel() of the tx_irq_time hrtimer to mcp251xfd_stop(). Link: https://lore.kernel.org/all/[email protected] Fixes: 169d00a ("can: mcp251xfd: add TX IRQ coalescing support") Cc: [email protected] # v5.18 Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent e3d4ee7 commit d5a972f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,6 +1650,7 @@ static int mcp251xfd_stop(struct net_device *ndev)
16501650
netif_stop_queue(ndev);
16511651
set_bit(MCP251XFD_FLAGS_DOWN, priv->flags);
16521652
hrtimer_cancel(&priv->rx_irq_timer);
1653+
hrtimer_cancel(&priv->tx_irq_timer);
16531654
mcp251xfd_chip_interrupts_disable(priv);
16541655
free_irq(ndev->irq, priv);
16551656
can_rx_offload_disable(&priv->offload);

0 commit comments

Comments
 (0)