dma-mapping: fix swapped dir/flags arguments to trace_dma_alloc_sgt_err

Sean Anderson · Christoph Hellwig · commit d5bbfbad58ec · 2024-11-08T14:56:39.000+01:00
trace_dma_alloc_sgt_err was called with the dir and flags arguments swapped. Fix this. Fixes: 68b6dbf ("dma-mapping: trace more error paths") Signed-off-by: Sean Anderson <sean.anderson@linux.dev> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202410302243.1wnTlPk3-lkp@intel.com/ Signed-off-by: Christoph Hellwig <hch@lst.de>
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
@@ -782,7 +782,7 @@ struct sg_table *dma_alloc_noncontiguous(struct device *dev, size_t size,
 		trace_dma_alloc_sgt(dev, sgt, size, dir, gfp, attrs);
 		debug_dma_map_sg(dev, sgt->sgl, sgt->orig_nents, 1, dir, attrs);
 	} else {
-		trace_dma_alloc_sgt_err(dev, NULL, 0, size, gfp, dir, attrs);
+		trace_dma_alloc_sgt_err(dev, NULL, 0, size, dir, gfp, attrs);
 	}
 	return sgt;
 }

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,7 @@ struct sg_table dma_alloc_noncontiguous(struct device dev, size_t size,`
`782`	`782`	`trace_dma_alloc_sgt(dev, sgt, size, dir, gfp, attrs);`
`783`	`783`	`debug_dma_map_sg(dev, sgt->sgl, sgt->orig_nents, 1, dir, attrs);`
`784`	`784`	`} else {`
`785`		`- trace_dma_alloc_sgt_err(dev, NULL, 0, size, gfp, dir, attrs);`
	`785`	`+ trace_dma_alloc_sgt_err(dev, NULL, 0, size, dir, gfp, attrs);`
`786`	`786`	`}`
`787`	`787`	`return sgt;`
`788`	`788`	`}`