Skip to content

Commit d6776bb

Browse files
mikeympe
authored andcommitted
cxl: Keep IRQ mappings on context teardown
Keep IRQ mappings on context teardown. This won't leak IRQs as if we allocate the mapping again, the generic code will give the same mapping used last time. Doing this works around a race in the generic code. Masking the interrupt introduces a race which can crash the kernel or result in IRQ that is never EOIed. The lost of EOI results in all subsequent mappings to the same HW IRQ never receiving an interrupt. We've seen this race with cxl test cases which are doing heavy context startup and teardown at the same time as heavy interrupt load. A fix to the generic code is being investigated also. Signed-off-by: Michael Neuling <[email protected]> Cc: [email protected] # 3.8 Tested-by: Andrew Donnellan <[email protected]> Acked-by: Ian Munsie <[email protected]> Tested-by: Vaibhav Jain <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
1 parent 4705e02 commit d6776bb

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/misc/cxl/irq.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ unsigned int cxl_map_irq(struct cxl *adapter, irq_hw_number_t hwirq,
203203
void cxl_unmap_irq(unsigned int virq, void *cookie)
204204
{
205205
free_irq(virq, cookie);
206-
irq_dispose_mapping(virq);
207206
}
208207

209208
int cxl_register_one_irq(struct cxl *adapter,

0 commit comments

Comments
 (0)