Skip to content

Commit d699594

Browse files
hansendctytso
authored andcommitted
ext4: remove extra IS_RDONLY() check
ext4_change_inode_journal_flag() is only called from one location: ext4_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Dave Kleikamp <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]>
1 parent 1330593 commit d699594

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/ext4/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3275,7 +3275,7 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val)
32753275
*/
32763276

32773277
journal = EXT4_JOURNAL(inode);
3278-
if (is_journal_aborted(journal) || IS_RDONLY(inode))
3278+
if (is_journal_aborted(journal))
32793279
return -EROFS;
32803280

32813281
jbd2_journal_lock_updates(journal);

0 commit comments

Comments
 (0)