Skip to content

Commit d6fcd28

Browse files
lenticularis39rostedt
authored andcommitted
rtla: Count missed trace events
Add function collect_missed_events to trace.c to act as a callback for tracefs_follow_missed_events, summing the number of total missed events into a new field missing_events of struct trace_instance. In case record->missed_events is negative, trace->missed_events is set to UINT64_MAX to signify an unknown number of events was missed. The callback is activated on initialization of the trace instance. Cc: John Kacur <[email protected]> Cc: Luis Goncalves <[email protected]> Cc: Gabriele Monaco <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Tomas Glozar <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent b91cfd9 commit d6fcd28

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

tools/tracing/rtla/src/trace.c

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,31 @@ collect_registered_events(struct tep_event *event, struct tep_record *record,
126126
return 0;
127127
}
128128

129+
/*
130+
* collect_missed_events - record number of missed events
131+
*
132+
* If rtla cannot keep up with events generated by tracer, events are going
133+
* to fall out of the ring buffer.
134+
* Collect how many events were missed so it can be reported to the user.
135+
*/
136+
static int
137+
collect_missed_events(struct tep_event *event, struct tep_record *record,
138+
int cpu, void *context)
139+
{
140+
struct trace_instance *trace = context;
141+
142+
if (trace->missed_events == UINT64_MAX)
143+
return 0;
144+
145+
if (record->missed_events > 0)
146+
trace->missed_events += record->missed_events;
147+
else
148+
/* Events missed but no data on how many */
149+
trace->missed_events = UINT64_MAX;
150+
151+
return 0;
152+
}
153+
129154
/*
130155
* trace_instance_destroy - destroy and free a rtla trace instance
131156
*/
@@ -181,6 +206,15 @@ int trace_instance_init(struct trace_instance *trace, char *tool_name)
181206
*/
182207
tracefs_trace_off(trace->inst);
183208

209+
/*
210+
* Collect the number of events missed due to tracefs buffer
211+
* overflow.
212+
*/
213+
trace->missed_events = 0;
214+
tracefs_follow_missed_events(trace->inst,
215+
collect_missed_events,
216+
trace);
217+
184218
return 0;
185219

186220
out_err:

tools/tracing/rtla/src/trace.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ struct trace_instance {
1717
struct tracefs_instance *inst;
1818
struct tep_handle *tep;
1919
struct trace_seq *seq;
20+
unsigned long long missed_events;
2021
};
2122

2223
int trace_instance_init(struct trace_instance *trace, char *tool_name);

0 commit comments

Comments
 (0)