Skip to content

Commit d71cf15

Browse files
liugang-gavinlinusw
authored andcommitted
gpio: mpc8xxx: Correct irq handler function
From the beginning of the gpio-mpc8xxx.c, the "handle_level_irq" has being used to handle GPIO interrupts in the PowerPC/Layerscape platforms. But actually, almost all PowerPC/Layerscape platforms assert an interrupt request upon either a high-to-low change or any change on the state of the signal. So the "handle_level_irq" is not reasonable for PowerPC/Layerscape GPIO interrupt, it should be "handle_edge_irq". Otherwise the system may lost some interrupts from the PIN's state changes. Signed-off-by: Liu Gang <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 6d8d271 commit d71cf15

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpio/gpio-mpc8xxx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ static int mpc8xxx_gpio_irq_map(struct irq_domain *h, unsigned int irq,
239239
irq_hw_number_t hwirq)
240240
{
241241
irq_set_chip_data(irq, h->host_data);
242-
irq_set_chip_and_handler(irq, &mpc8xxx_irq_chip, handle_level_irq);
242+
irq_set_chip_and_handler(irq, &mpc8xxx_irq_chip, handle_edge_irq);
243243

244244
return 0;
245245
}

0 commit comments

Comments
 (0)