Skip to content

Commit d76bf52

Browse files
jnikulahverkuil
authored andcommitted
media: cec: include linux/debugfs.h and linux/seq_file.h where needed
Having cec.h include linux/debugfs.h leads to all users of all cec headers include and depend on debugfs.h and its dependencies for no reason. Drop the include from cec.h, and include debugfs.h and seq_file.h where needed. Sort all the modified include lists while at it. Signed-off-by: Jani Nikula <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
1 parent 9229b53 commit d76bf52

File tree

6 files changed

+14
-10
lines changed

6 files changed

+14
-10
lines changed

drivers/media/cec/core/cec-adap.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@
77

88
#include <linux/errno.h>
99
#include <linux/init.h>
10-
#include <linux/module.h>
1110
#include <linux/kernel.h>
1211
#include <linux/kmod.h>
1312
#include <linux/ktime.h>
14-
#include <linux/slab.h>
1513
#include <linux/mm.h>
14+
#include <linux/module.h>
15+
#include <linux/seq_file.h>
16+
#include <linux/slab.h>
1617
#include <linux/string.h>
1718
#include <linux/types.h>
1819

drivers/media/cec/core/cec-core.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55
* Copyright 2016 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
66
*/
77

8+
#include <linux/debugfs.h>
89
#include <linux/errno.h>
910
#include <linux/init.h>
10-
#include <linux/module.h>
1111
#include <linux/kernel.h>
1212
#include <linux/kmod.h>
13-
#include <linux/slab.h>
1413
#include <linux/mm.h>
14+
#include <linux/module.h>
15+
#include <linux/slab.h>
1516
#include <linux/string.h>
1617
#include <linux/types.h>
1718

drivers/media/cec/core/cec-pin-error-inj.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
*/
55

66
#include <linux/delay.h>
7-
#include <linux/slab.h>
87
#include <linux/sched/types.h>
8+
#include <linux/seq_file.h>
9+
#include <linux/slab.h>
910

1011
#include <media/cec-pin.h>
1112
#include "cec-pin-priv.h"

drivers/media/cec/core/cec-pin.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
*/
55

66
#include <linux/delay.h>
7-
#include <linux/slab.h>
87
#include <linux/sched/types.h>
8+
#include <linux/seq_file.h>
9+
#include <linux/slab.h>
910

1011
#include <media/cec-pin.h>
1112
#include "cec-pin-priv.h"

drivers/media/cec/platform/cec-gpio/cec-gpio.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
* Copyright 2017 Cisco Systems, Inc. and/or its affiliates. All rights reserved.
44
*/
55

6-
#include <linux/module.h>
7-
#include <linux/interrupt.h>
86
#include <linux/delay.h>
9-
#include <linux/platform_device.h>
107
#include <linux/gpio/consumer.h>
8+
#include <linux/interrupt.h>
9+
#include <linux/module.h>
10+
#include <linux/platform_device.h>
11+
#include <linux/seq_file.h>
1112
#include <media/cec-notifier.h>
1213
#include <media/cec-pin.h>
1314

include/media/cec.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
#include <linux/poll.h>
1212
#include <linux/fs.h>
13-
#include <linux/debugfs.h>
1413
#include <linux/device.h>
1514
#include <linux/cdev.h>
1615
#include <linux/kthread.h>

0 commit comments

Comments
 (0)