net: macb: fix for pause frame receive enable bit

pthombarcdns · kuba-moo · commit d7739b0b6d15 · 2020-09-06T11:58:59.000-07:00
PAE bit of NCFGR register, when set, pauses transmission if a non-zero 802.3 classic pause frame is received. Fixes: 7897b07 ("net: macb: convert to phylink") Signed-off-by: Parshuram Thombare <pthombar@cadence.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
@@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,
 				ctrl |= GEM_BIT(GBE);
 		}
 
-		/* We do not support MLO_PAUSE_RX yet */
-		if (tx_pause)
+		if (rx_pause)
 			ctrl |= MACB_BIT(PAE);
 
 		macb_set_tx_clk(bp->tx_clk, speed, ndev);

Original file line number	Diff line number	Diff line change
`@@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,`
`647`	`647`	`ctrl \|= GEM_BIT(GBE);`
`648`	`648`	`}`
`649`	`649`
`650`		`- /* We do not support MLO_PAUSE_RX yet */`
`651`		`- if (tx_pause)`
	`650`	`+ if (rx_pause)`
`652`	`651`	`ctrl \|= MACB_BIT(PAE);`
`653`	`652`
`654`	`653`	`macb_set_tx_clk(bp->tx_clk, speed, ndev);`