Skip to content

Commit d7f8424

Browse files
egrumbachjmberg-intel
authored andcommitted
mac80211: fix the TID on NDPs sent as EOSP carrier
In the commit below, I forgot to translate the mac80211's AC to QoS IE order. Moreover, the condition in the if was wrong. Fix both issues. This bug would hit only with clients that didn't set all the ACs as delivery enabled. Fixes: f438ceb ("mac80211: uapsd_queues is in QoS IE order") Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Johannes Berg <[email protected]>
1 parent c38c39b commit d7f8424

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/mac80211/sta_info.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1501,8 +1501,8 @@ ieee80211_sta_ps_deliver_response(struct sta_info *sta,
15011501

15021502
/* This will evaluate to 1, 3, 5 or 7. */
15031503
for (ac = IEEE80211_AC_VO; ac < IEEE80211_NUM_ACS; ac++)
1504-
if (ignored_acs & BIT(ac))
1505-
continue;
1504+
if (!(ignored_acs & ieee80211_ac_to_qos_mask[ac]))
1505+
break;
15061506
tid = 7 - 2 * ac;
15071507

15081508
ieee80211_send_null_response(sta, tid, reason, true, false);

0 commit comments

Comments
 (0)