Skip to content

Commit d81d0e4

Browse files
tprrtbroonie
authored andcommitted
spi: spl022: fix Microwire full duplex mode
There are missing braces in the function that verify controller parameters, then an error is always returned when the parameter to select Microwire frames operation is used on devices allowing it. Signed-off-by: Thomas Perrot <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent f09f6df commit d81d0e4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/spi/spi-pl022.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,12 +1716,13 @@ static int verify_controller_parameters(struct pl022 *pl022,
17161716
return -EINVAL;
17171717
}
17181718
} else {
1719-
if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX)
1719+
if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) {
17201720
dev_err(&pl022->adev->dev,
17211721
"Microwire half duplex mode requested,"
17221722
" but this is only available in the"
17231723
" ST version of PL022\n");
1724-
return -EINVAL;
1724+
return -EINVAL;
1725+
}
17251726
}
17261727
}
17271728
return 0;

0 commit comments

Comments
 (0)