Skip to content

Commit d82574a

Browse files
gregkhjmberg-intel
authored andcommitted
cfg80211: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by: Greg Kroah-Hartman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent dc3998e commit d82574a

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

net/wireless/core.c

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,10 @@ int cfg80211_dev_rename(struct cfg80211_registered_device *rdev,
142142
if (result)
143143
return result;
144144

145-
if (rdev->wiphy.debugfsdir &&
146-
!debugfs_rename(rdev->wiphy.debugfsdir->d_parent,
147-
rdev->wiphy.debugfsdir,
148-
rdev->wiphy.debugfsdir->d_parent,
149-
newname))
150-
pr_err("failed to rename debugfs dir to %s!\n", newname);
145+
if (rdev->wiphy.debugfsdir)
146+
debugfs_rename(rdev->wiphy.debugfsdir->d_parent,
147+
rdev->wiphy.debugfsdir,
148+
rdev->wiphy.debugfsdir->d_parent, newname);
151149

152150
nl80211_notify_wiphy(rdev, NL80211_CMD_NEW_WIPHY);
153151

@@ -899,11 +897,8 @@ int wiphy_register(struct wiphy *wiphy)
899897
cfg80211_rdev_list_generation++;
900898

901899
/* add to debugfs */
902-
rdev->wiphy.debugfsdir =
903-
debugfs_create_dir(wiphy_name(&rdev->wiphy),
904-
ieee80211_debugfs_dir);
905-
if (IS_ERR(rdev->wiphy.debugfsdir))
906-
rdev->wiphy.debugfsdir = NULL;
900+
rdev->wiphy.debugfsdir = debugfs_create_dir(wiphy_name(&rdev->wiphy),
901+
ieee80211_debugfs_dir);
907902

908903
cfg80211_debugfs_rdev_add(rdev);
909904
nl80211_notify_wiphy(rdev, NL80211_CMD_NEW_WIPHY);

0 commit comments

Comments
 (0)