Skip to content

Commit d952cfa

Browse files
committed
kbuild: do not suppress Kconfig prompts for silent build
When a new CONFIG option is available, Kbuild shows a prompt to get the user input. $ make [ snip ] Core Scheduling for SMT (SCHED_CORE) [N/y/?] (NEW) This is the only interactive place in the build process. Commit 174a1dc ("kbuild: sink stdout from cmd for silent build") suppressed Kconfig prompts as well because syncconfig is invoked by the 'cmd' macro. You cannot notice the fact that Kconfig is waiting for the user input. Use 'kecho' to show the equivalent short log without suppressing stdout from sub-make. Fixes: 174a1dc ("kbuild: sink stdout from cmd for silent build") Reported-by: Tetsuo Handa <[email protected]> Signed-off-by: Masahiro Yamada <[email protected]> Tested-by: Tetsuo Handa <[email protected]>
1 parent 5df99be commit d952cfa

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Makefile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -728,11 +728,12 @@ $(KCONFIG_CONFIG):
728728
# This exploits the 'multi-target pattern rule' trick.
729729
# The syncconfig should be executed only once to make all the targets.
730730
# (Note: use the grouped target '&:' when we bump to GNU Make 4.3)
731-
quiet_cmd_syncconfig = SYNC $@
732-
cmd_syncconfig = $(MAKE) -f $(srctree)/Makefile syncconfig
733-
731+
#
732+
# Do not use $(call cmd,...) here. That would suppress prompts from syncconfig,
733+
# so you cannot notice that Kconfig is waiting for the user input.
734734
%/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h: $(KCONFIG_CONFIG)
735-
+$(call cmd,syncconfig)
735+
$(Q)$(kecho) " SYNC $@"
736+
$(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
736737
else # !may-sync-config
737738
# External modules and some install targets need include/generated/autoconf.h
738739
# and include/config/auto.conf but do not care if they are up-to-date.

0 commit comments

Comments
 (0)