Skip to content

Commit d965a54

Browse files
ffainellidavem330
authored andcommitted
net: dsa: b53: Ensure the default VID is untagged
We need to ensure that the default VID is untagged otherwise the switch will be sending tagged frames and the results can be problematic. This is especially true with b53 switches that use VID 0 as their default VLAN since VID 0 has a special meaning. Fixes: fea8335 ("net: dsa: b53: Fix default VLAN ID") Fixes: 061f6a5 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation") Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 82d81bb commit d965a54

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1366,6 +1366,9 @@ void b53_vlan_add(struct dsa_switch *ds, int port,
13661366

13671367
b53_get_vlan_entry(dev, vid, vl);
13681368

1369+
if (vid == 0 && vid == b53_default_pvid(dev))
1370+
untagged = true;
1371+
13691372
vl->members |= BIT(port);
13701373
if (untagged && !dsa_is_cpu_port(ds, port))
13711374
vl->untag |= BIT(port);

0 commit comments

Comments
 (0)