cgroup: fix a leak when percpu_ref_init() fails

lizf-os · htejun · commit da0a12caffad · 2013-07-31T06:13:25.000-04:00
ss-&gt;css_free() is not called when perfcpu_ref_init() fails.

Signed-off-by: Li Zefan &lt;lizefan@huawei.com&gt;
Signed-off-by: Tejun Heo &lt;tj@kernel.org&gt;
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
@@ -4344,8 +4344,10 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 		}
 
 		err = percpu_ref_init(&css->refcnt, css_release);
-		if (err)
+		if (err) {
+			ss->css_free(cgrp);
 			goto err_free_all;
+		}
 
 		init_cgroup_css(css, ss, cgrp);
 

Original file line number	Diff line number	Diff line change
`@@ -4344,8 +4344,10 @@ static long cgroup_create(struct cgroup parent, struct dentry dentry,`
`4344`	`4344`	`}`
`4345`	`4345`
`4346`	`4346`	`err = percpu_ref_init(&css->refcnt, css_release);`
`4347`		`- if (err)`
	`4347`	`+ if (err) {`
	`4348`	`+ ss->css_free(cgrp);`
`4348`	`4349`	`goto err_free_all;`
	`4350`	`+ }`
`4349`	`4351`
`4350`	`4352`	`init_cgroup_css(css, ss, cgrp);`
`4351`	`4353`