bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only.

Michael Chan · davem330 · commit dac0490718bd · 2018-05-08T10:14:21.000-04:00
Only non-NPAR PFs need to actively check and manage unsupported link
speeds.  NPAR functions and VFs do not control the link speed and
should skip the unsupported speed detection logic, to avoid warning
messages from firmware rejecting the unsupported firmware calls.

Signed-off-by: Michael Chan &lt;michael.chan@broadcom.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6462,6 +6462,9 @@ static int bnxt_update_link(struct bnxt *bp, bool chng_link_state)
 	}
 	mutex_unlock(&bp->hwrm_cmd_lock);
 
+	if (!BNXT_SINGLE_PF(bp))
+		return 0;
+
 	diff = link_info->support_auto_speeds ^ link_info->advertising;
 	if ((link_info->support_auto_speeds | diff) !=
 	    link_info->support_auto_speeds) {

Original file line number	Diff line number	Diff line change
`@@ -6462,6 +6462,9 @@ static int bnxt_update_link(struct bnxt *bp, bool chng_link_state)`
`6462`	`6462`	`}`
`6463`	`6463`	`mutex_unlock(&bp->hwrm_cmd_lock);`
`6464`	`6464`
	`6465`	`+ if (!BNXT_SINGLE_PF(bp))`
	`6466`	`+ return 0;`
	`6467`	`+`
`6465`	`6468`	`diff = link_info->support_auto_speeds ^ link_info->advertising;`
`6466`	`6469`	`if ((link_info->support_auto_speeds \| diff) !=`
`6467`	`6470`	`link_info->support_auto_speeds) {`