Skip to content

Commit dac5fed

Browse files
changbindugregkh
authored andcommitted
perf top: Fix error handling in cmd_top()
[ Upstream commit 70c819e ] We should go to the cleanup path, to avoid leaks, detected using gcc's ASan. Signed-off-by: Changbin Du <[email protected]> Reviewed-by: Jiri Olsa <[email protected]> Cc: Alexei Starovoitov <[email protected]> Cc: Daniel Borkmann <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Steven Rostedt (VMware) <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 801a590 commit dac5fed

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/perf/builtin-top.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1345,8 +1345,9 @@ int cmd_top(int argc, const char **argv)
13451345
goto out_delete_evlist;
13461346

13471347
symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
1348-
if (symbol__init(NULL) < 0)
1349-
return -1;
1348+
status = symbol__init(NULL);
1349+
if (status < 0)
1350+
goto out_delete_evlist;
13501351

13511352
sort__setup_elide(stdout);
13521353

0 commit comments

Comments
 (0)