iwlwifi: dbg_ini: fix memory leak in alloc_sgtable

Navidem · gregkh · commit db1fb5a39747 · 2020-01-17T19:45:43.000+01:00
commit b4b814f upstream. In alloc_sgtable if alloc_page fails, the alocated table should be released. Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -532,6 +532,7 @@ static struct scatterlist *alloc_sgtable(int size)
 				if (new_page)
 					__free_page(new_page);
 			}
+			kfree(table);
 			return NULL;
 		}
 		alloc_size = min_t(int, size, PAGE_SIZE);

Original file line number	Diff line number	Diff line change
`@@ -532,6 +532,7 @@ static struct scatterlist *alloc_sgtable(int size)`
`532`	`532`	`if (new_page)`
`533`	`533`	`__free_page(new_page);`
`534`	`534`	`}`
	`535`	`+ kfree(table);`
`535`	`536`	`return NULL;`
`536`	`537`	`}`
`537`	`538`	`alloc_size = min_t(int, size, PAGE_SIZE);`