Skip to content

Commit db8fcef

Browse files
aprzywaravikivity
authored andcommitted
KVM: move complete_insn_gp() into x86.c
move the complete_insn_gp() helper function out of the VMX part into the generic x86 part to make it usable by SVM. Signed-off-by: Andre Przywara <[email protected]> Signed-off-by: Marcelo Tosatti <[email protected]>
1 parent eea1cff commit db8fcef

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

arch/x86/include/asm/kvm_host.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -828,4 +828,6 @@ void kvm_arch_async_page_ready(struct kvm_vcpu *vcpu,
828828
bool kvm_arch_can_inject_async_page_present(struct kvm_vcpu *vcpu);
829829
extern bool kvm_find_async_pf_gfn(struct kvm_vcpu *vcpu, gfn_t gfn);
830830

831+
void kvm_complete_insn_gp(struct kvm_vcpu *vcpu, int err);
832+
831833
#endif /* _ASM_X86_KVM_HOST_H */

arch/x86/kvm/vmx.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3147,14 +3147,6 @@ vmx_patch_hypercall(struct kvm_vcpu *vcpu, unsigned char *hypercall)
31473147
hypercall[2] = 0xc1;
31483148
}
31493149

3150-
static void complete_insn_gp(struct kvm_vcpu *vcpu, int err)
3151-
{
3152-
if (err)
3153-
kvm_inject_gp(vcpu, 0);
3154-
else
3155-
skip_emulated_instruction(vcpu);
3156-
}
3157-
31583150
static int handle_cr(struct kvm_vcpu *vcpu)
31593151
{
31603152
unsigned long exit_qualification, val;
@@ -3172,21 +3164,21 @@ static int handle_cr(struct kvm_vcpu *vcpu)
31723164
switch (cr) {
31733165
case 0:
31743166
err = kvm_set_cr0(vcpu, val);
3175-
complete_insn_gp(vcpu, err);
3167+
kvm_complete_insn_gp(vcpu, err);
31763168
return 1;
31773169
case 3:
31783170
err = kvm_set_cr3(vcpu, val);
3179-
complete_insn_gp(vcpu, err);
3171+
kvm_complete_insn_gp(vcpu, err);
31803172
return 1;
31813173
case 4:
31823174
err = kvm_set_cr4(vcpu, val);
3183-
complete_insn_gp(vcpu, err);
3175+
kvm_complete_insn_gp(vcpu, err);
31843176
return 1;
31853177
case 8: {
31863178
u8 cr8_prev = kvm_get_cr8(vcpu);
31873179
u8 cr8 = kvm_register_read(vcpu, reg);
31883180
err = kvm_set_cr8(vcpu, cr8);
3189-
complete_insn_gp(vcpu, err);
3181+
kvm_complete_insn_gp(vcpu, err);
31903182
if (irqchip_in_kernel(vcpu->kvm))
31913183
return 1;
31923184
if (cr8_prev <= cr8)

arch/x86/kvm/x86.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,15 @@ void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned nr)
334334
}
335335
EXPORT_SYMBOL_GPL(kvm_requeue_exception);
336336

337+
void kvm_complete_insn_gp(struct kvm_vcpu *vcpu, int err)
338+
{
339+
if (err)
340+
kvm_inject_gp(vcpu, 0);
341+
else
342+
kvm_x86_ops->skip_emulated_instruction(vcpu);
343+
}
344+
EXPORT_SYMBOL_GPL(kvm_complete_insn_gp);
345+
337346
void kvm_inject_page_fault(struct kvm_vcpu *vcpu, struct x86_exception *fault)
338347
{
339348
++vcpu->stat.pf_guest;

0 commit comments

Comments
 (0)