Skip to content

Commit dc972a6

Browse files
committed
Merge tag 'mmc-v4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
Pull MMC fixes from Ulf Hansson: - sdhci-pci: Fix voltage switch for some Intel host controllers - tmio: remove broken and noisy debug macro * tag 'mmc-v4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc: mmc: sdhci-pci: Fix voltage switch for some Intel host controllers mmc: tmio: remove broken and noisy debug macro
2 parents fc46820 + 6ae0336 commit dc972a6

File tree

2 files changed

+15
-47
lines changed

2 files changed

+15
-47
lines changed

drivers/mmc/host/sdhci-pci-core.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,7 @@ static const struct sdhci_pci_fixes sdhci_intel_pch_sdio = {
392392

393393
enum {
394394
INTEL_DSM_FNS = 0,
395+
INTEL_DSM_V18_SWITCH = 3,
395396
INTEL_DSM_DRV_STRENGTH = 9,
396397
INTEL_DSM_D3_RETUNE = 10,
397398
};
@@ -557,6 +558,19 @@ static void intel_hs400_enhanced_strobe(struct mmc_host *mmc,
557558
sdhci_writel(host, val, INTEL_HS400_ES_REG);
558559
}
559560

561+
static void sdhci_intel_voltage_switch(struct sdhci_host *host)
562+
{
563+
struct sdhci_pci_slot *slot = sdhci_priv(host);
564+
struct intel_host *intel_host = sdhci_pci_priv(slot);
565+
struct device *dev = &slot->chip->pdev->dev;
566+
u32 result = 0;
567+
int err;
568+
569+
err = intel_dsm(intel_host, dev, INTEL_DSM_V18_SWITCH, &result);
570+
pr_debug("%s: %s DSM error %d result %u\n",
571+
mmc_hostname(host->mmc), __func__, err, result);
572+
}
573+
560574
static const struct sdhci_ops sdhci_intel_byt_ops = {
561575
.set_clock = sdhci_set_clock,
562576
.set_power = sdhci_intel_set_power,
@@ -565,6 +579,7 @@ static const struct sdhci_ops sdhci_intel_byt_ops = {
565579
.reset = sdhci_reset,
566580
.set_uhs_signaling = sdhci_set_uhs_signaling,
567581
.hw_reset = sdhci_pci_hw_reset,
582+
.voltage_switch = sdhci_intel_voltage_switch,
568583
};
569584

570585
static void byt_read_dsm(struct sdhci_pci_slot *slot)

drivers/mmc/host/tmio_mmc_core.c

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -129,50 +129,6 @@ static int tmio_mmc_next_sg(struct tmio_mmc_host *host)
129129

130130
#define CMDREQ_TIMEOUT 5000
131131

132-
#ifdef CONFIG_MMC_DEBUG
133-
134-
#define STATUS_TO_TEXT(a, status, i) \
135-
do { \
136-
if ((status) & TMIO_STAT_##a) { \
137-
if ((i)++) \
138-
printk(KERN_DEBUG " | "); \
139-
printk(KERN_DEBUG #a); \
140-
} \
141-
} while (0)
142-
143-
static void pr_debug_status(u32 status)
144-
{
145-
int i = 0;
146-
147-
pr_debug("status: %08x = ", status);
148-
STATUS_TO_TEXT(CARD_REMOVE, status, i);
149-
STATUS_TO_TEXT(CARD_INSERT, status, i);
150-
STATUS_TO_TEXT(SIGSTATE, status, i);
151-
STATUS_TO_TEXT(WRPROTECT, status, i);
152-
STATUS_TO_TEXT(CARD_REMOVE_A, status, i);
153-
STATUS_TO_TEXT(CARD_INSERT_A, status, i);
154-
STATUS_TO_TEXT(SIGSTATE_A, status, i);
155-
STATUS_TO_TEXT(CMD_IDX_ERR, status, i);
156-
STATUS_TO_TEXT(STOPBIT_ERR, status, i);
157-
STATUS_TO_TEXT(ILL_FUNC, status, i);
158-
STATUS_TO_TEXT(CMD_BUSY, status, i);
159-
STATUS_TO_TEXT(CMDRESPEND, status, i);
160-
STATUS_TO_TEXT(DATAEND, status, i);
161-
STATUS_TO_TEXT(CRCFAIL, status, i);
162-
STATUS_TO_TEXT(DATATIMEOUT, status, i);
163-
STATUS_TO_TEXT(CMDTIMEOUT, status, i);
164-
STATUS_TO_TEXT(RXOVERFLOW, status, i);
165-
STATUS_TO_TEXT(TXUNDERRUN, status, i);
166-
STATUS_TO_TEXT(RXRDY, status, i);
167-
STATUS_TO_TEXT(TXRQ, status, i);
168-
STATUS_TO_TEXT(ILL_ACCESS, status, i);
169-
printk("\n");
170-
}
171-
172-
#else
173-
#define pr_debug_status(s) do { } while (0)
174-
#endif
175-
176132
static void tmio_mmc_enable_sdio_irq(struct mmc_host *mmc, int enable)
177133
{
178134
struct tmio_mmc_host *host = mmc_priv(mmc);
@@ -762,9 +718,6 @@ irqreturn_t tmio_mmc_irq(int irq, void *devid)
762718
status = sd_ctrl_read16_and_16_as_32(host, CTL_STATUS);
763719
ireg = status & TMIO_MASK_IRQ & ~host->sdcard_irq_mask;
764720

765-
pr_debug_status(status);
766-
pr_debug_status(ireg);
767-
768721
/* Clear the status except the interrupt status */
769722
sd_ctrl_write32_as_16_and_16(host, CTL_STATUS, TMIO_MASK_IRQ);
770723

0 commit comments

Comments
 (0)