Skip to content

Commit dd5f1b0

Browse files
author
Marc Zyngier
committed
irqchip/gic-v3: Fix ICC_SGI1R_EL1.INTID decoding mask
The INTID mask is wrong, and is made a signed value, which has nteresting effects in the KVM emulation. Let's sanitize it. Cc: [email protected] Signed-off-by: Marc Zyngier <[email protected]>
1 parent 1a695a9 commit dd5f1b0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/irqchip/arm-gic-v3.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@
305305
#define ICC_SGI1R_AFFINITY_1_SHIFT 16
306306
#define ICC_SGI1R_AFFINITY_1_MASK (0xff << ICC_SGI1R_AFFINITY_1_SHIFT)
307307
#define ICC_SGI1R_SGI_ID_SHIFT 24
308-
#define ICC_SGI1R_SGI_ID_MASK (0xff << ICC_SGI1R_SGI_ID_SHIFT)
308+
#define ICC_SGI1R_SGI_ID_MASK (0xfULL << ICC_SGI1R_SGI_ID_SHIFT)
309309
#define ICC_SGI1R_AFFINITY_2_SHIFT 32
310310
#define ICC_SGI1R_AFFINITY_2_MASK (0xffULL << ICC_SGI1R_AFFINITY_1_SHIFT)
311311
#define ICC_SGI1R_IRQ_ROUTING_MODE_BIT 40

0 commit comments

Comments
 (0)