Skip to content

Commit dd7328e

Browse files
Dan Carpentermartinkpetersen
authored andcommitted
fnic: pci_dma_mapping_error() doesn't return an error code
pci_dma_mapping_error() returns true on error and false on success. Fixes: fd6ddfa ('fnic: check pci_map_single() return value') Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent de8c36b commit dd7328e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/scsi/fnic/fnic_fcs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -954,8 +954,8 @@ int fnic_alloc_rq_frame(struct vnic_rq *rq)
954954
skb_put(skb, len);
955955
pa = pci_map_single(fnic->pdev, skb->data, len, PCI_DMA_FROMDEVICE);
956956

957-
r = pci_dma_mapping_error(fnic->pdev, pa);
958-
if (r) {
957+
if (pci_dma_mapping_error(fnic->pdev, pa)) {
958+
r = -ENOMEM;
959959
printk(KERN_ERR "PCI mapping failed with error %d\n", r);
960960
goto free_skb;
961961
}
@@ -1093,8 +1093,8 @@ static int fnic_send_frame(struct fnic *fnic, struct fc_frame *fp)
10931093

10941094
pa = pci_map_single(fnic->pdev, eth_hdr, tot_len, PCI_DMA_TODEVICE);
10951095

1096-
ret = pci_dma_mapping_error(fnic->pdev, pa);
1097-
if (ret) {
1096+
if (pci_dma_mapping_error(fnic->pdev, pa)) {
1097+
ret = -ENOMEM;
10981098
printk(KERN_ERR "DMA map failed with error %d\n", ret);
10991099
goto free_skb_on_err;
11001100
}

0 commit comments

Comments
 (0)