Skip to content

Commit de3d01f

Browse files
XidianGeneralBoris Ostrovsky
authored andcommitted
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_reg_add
pcistub_reg_add() is never called in atomic context. pcistub_reg_add() is only called by pcistub_quirk_add, which is only set in DRIVER_ATTR(). Despite never getting called from atomic context, pcistub_reg_add() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <[email protected]> Reviewed-by: Boris Ostrovsky <[email protected]> Signed-off-by: Boris Ostrovsky <[email protected]>
1 parent 230d211 commit de3d01f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/xen/xen-pciback/pci_stub.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1149,7 +1149,7 @@ static int pcistub_reg_add(int domain, int bus, int slot, int func,
11491149
}
11501150
dev = psdev->dev;
11511151

1152-
field = kzalloc(sizeof(*field), GFP_ATOMIC);
1152+
field = kzalloc(sizeof(*field), GFP_KERNEL);
11531153
if (!field) {
11541154
err = -ENOMEM;
11551155
goto out;

0 commit comments

Comments
 (0)