Skip to content

Commit de46584

Browse files
richardcochrandavem330
authored andcommitted
ptp: clarify the clock_name sysfs attribute
There has been some confusion among PHC driver authors about the intended purpose of the clock_name attribute. This patch expands the documation in order to clarify how the clock_name field should be understood. Signed-off-by: Richard Cochran <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1ef7615 commit de46584

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Documentation/ABI/testing/sysfs-ptp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@ Date: September 2010
1919
Contact: Richard Cochran <[email protected]>
2020
Description:
2121
This file contains the name of the PTP hardware clock
22-
as a human readable string.
22+
as a human readable string. The purpose of this
23+
attribute is to provide the user with a "friendly
24+
name" and to help distinguish PHY based devices from
25+
MAC based ones. The string does not necessarily have
26+
to be any kind of unique id.
2327

2428
What: /sys/class/ptp/ptpN/max_adjustment
2529
Date: September 2010

include/linux/ptp_clock_kernel.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ struct ptp_clock_request {
4242
* struct ptp_clock_info - decribes a PTP hardware clock
4343
*
4444
* @owner: The clock driver should set to THIS_MODULE.
45-
* @name: A short name to identify the clock.
45+
* @name: A short "friendly name" to identify the clock and to
46+
* help distinguish PHY based devices from MAC based ones.
47+
* The string is not meant to be a unique id.
4648
* @max_adj: The maximum possible frequency adjustment, in parts per billon.
4749
* @n_alarm: The number of programmable alarms.
4850
* @n_ext_ts: The number of external time stamp channels.

0 commit comments

Comments
 (0)