Skip to content

Commit de70981

Browse files
hramamurthy12kuba-moo
authored andcommitted
gve: unlink old napi when stopping a queue using queue API
When a queue is stopped using the ndo queue API, before destroying its page pool, the associated NAPI instance needs to be unlinked to avoid warnings. Handle this by calling page_pool_disable_direct_recycling() when stopping a queue. Cc: [email protected] Fixes: ebdfae0 ("gve: adopt page pool for DQ RDA mode") Reviewed-by: Praveen Kaligineedi <[email protected]> Signed-off-by: Harshitha Ramamurthy <[email protected]> Reviewed-by: Jacob Keller <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 01c9c12 commit de70981

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/google/gve/gve_rx_dqo.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,12 @@ static void gve_rx_reset_ring_dqo(struct gve_priv *priv, int idx)
109109
void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)
110110
{
111111
int ntfy_idx = gve_rx_idx_to_ntfy(priv, idx);
112+
struct gve_rx_ring *rx = &priv->rx[idx];
112113

113114
if (!gve_rx_was_added_to_block(priv, idx))
114115
return;
115116

117+
page_pool_disable_direct_recycling(rx->dqo.page_pool);
116118
gve_remove_napi(priv, ntfy_idx);
117119
gve_rx_remove_from_block(priv, idx);
118120
gve_rx_reset_ring_dqo(priv, idx);

0 commit comments

Comments
 (0)