Skip to content

Commit deb4b9d

Browse files
committed
Merge tag 'for-linus-6.7a-rc4-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip
Pull xen fixes from Juergen Gross: - A fix for the Xen event driver setting the correct return value when experiencing an allocation failure - A fix for allocating space for a struct in the percpu area to not cross page boundaries (this one is for x86, a similar one for Arm was already in the pull request for rc3) * tag 'for-linus-6.7a-rc4-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip: xen/events: fix error code in xen_bind_pirq_msi_to_irq() x86/xen: fix percpu vcpu_info allocation
2 parents 669fc83 + 7f3da4b commit deb4b9d

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

arch/x86/xen/enlighten.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,12 @@ EXPORT_SYMBOL_GPL(hypercall_page);
3333
* and xen_vcpu_setup for details. By default it points to share_info->vcpu_info
3434
* but during boot it is switched to point to xen_vcpu_info.
3535
* The pointer is used in xen_evtchn_do_upcall to acknowledge pending events.
36+
* Make sure that xen_vcpu_info doesn't cross a page boundary by making it
37+
* cache-line aligned (the struct is guaranteed to have a size of 64 bytes,
38+
* which matches the cache line size of 64-bit x86 processors).
3639
*/
3740
DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu);
38-
DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
41+
DEFINE_PER_CPU_ALIGNED(struct vcpu_info, xen_vcpu_info);
3942

4043
/* Linux <-> Xen vCPU id mapping */
4144
DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
@@ -160,6 +163,7 @@ void xen_vcpu_setup(int cpu)
160163
int err;
161164
struct vcpu_info *vcpup;
162165

166+
BUILD_BUG_ON(sizeof(*vcpup) > SMP_CACHE_BYTES);
163167
BUG_ON(HYPERVISOR_shared_info == &xen_dummy_shared_info);
164168

165169
/*

arch/x86/xen/xen-ops.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ extern void *xen_initial_gdt;
2121
struct trap_info;
2222
void xen_copy_trap_info(struct trap_info *traps);
2323

24-
DECLARE_PER_CPU(struct vcpu_info, xen_vcpu_info);
24+
DECLARE_PER_CPU_ALIGNED(struct vcpu_info, xen_vcpu_info);
2525
DECLARE_PER_CPU(unsigned long, xen_cr3);
2626
DECLARE_PER_CPU(unsigned long, xen_current_cr3);
2727

drivers/xen/events/events_base.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1110,8 +1110,10 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
11101110

11111111
for (i = 0; i < nvec; i++) {
11121112
info = xen_irq_init(irq + i);
1113-
if (!info)
1113+
if (!info) {
1114+
ret = -ENOMEM;
11141115
goto error_irq;
1116+
}
11151117

11161118
irq_set_chip_and_handler_name(irq + i, &xen_pirq_chip, handle_edge_irq, name);
11171119

0 commit comments

Comments
 (0)