Skip to content

Commit deb9d57

Browse files
Jeff Johnsonkuba-moo
authored andcommitted
net: amd: add missing MODULE_DESCRIPTION() macros
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/a2065.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/ariadne.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/atarilance.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/hplance.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/7990.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/mvme147.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/ethernet/amd/sun3lance.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes drivers/net/ethernet/amd/lance.c which, although it did not produce a warning with the m68k allmodconfig configuration, may cause this warning with other configurations. Signed-off-by: Jeff Johnson <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/20240618-md-m68k-drivers-net-ethernet-amd-v1-1-50ee7a9ad50e@quicinc.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent e6fed01 commit deb9d57

File tree

8 files changed

+8
-0
lines changed

8 files changed

+8
-0
lines changed

drivers/net/ethernet/amd/7990.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,4 +667,5 @@ void lance_poll(struct net_device *dev)
667667
EXPORT_SYMBOL_GPL(lance_poll);
668668
#endif
669669

670+
MODULE_DESCRIPTION("LANCE Ethernet IC generic routines");
670671
MODULE_LICENSE("GPL");

drivers/net/ethernet/amd/a2065.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -781,4 +781,5 @@ static void __exit a2065_cleanup_module(void)
781781
module_init(a2065_init_module);
782782
module_exit(a2065_cleanup_module);
783783

784+
MODULE_DESCRIPTION("Commodore A2065 Ethernet driver");
784785
MODULE_LICENSE("GPL");

drivers/net/ethernet/amd/ariadne.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -790,4 +790,5 @@ static void __exit ariadne_cleanup_module(void)
790790
module_init(ariadne_init_module);
791791
module_exit(ariadne_cleanup_module);
792792

793+
MODULE_DESCRIPTION("Ariadne Ethernet Driver");
793794
MODULE_LICENSE("GPL");

drivers/net/ethernet/amd/atarilance.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ static int lance_debug = 1;
7979
#endif
8080
module_param(lance_debug, int, 0);
8181
MODULE_PARM_DESC(lance_debug, "atarilance debug level (0-3)");
82+
MODULE_DESCRIPTION("Atari LANCE Ethernet driver");
8283
MODULE_LICENSE("GPL");
8384

8485
/* Print debug messages on probing? */

drivers/net/ethernet/amd/hplance.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,4 +234,5 @@ static void __exit hplance_cleanup_module(void)
234234
module_init(hplance_init_module);
235235
module_exit(hplance_cleanup_module);
236236

237+
MODULE_DESCRIPTION("HP300 on-board LANCE Ethernet driver");
237238
MODULE_LICENSE("GPL");

drivers/net/ethernet/amd/lance.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,7 @@ static void __exit lance_cleanup_module(void)
385385
}
386386
module_exit(lance_cleanup_module);
387387
#endif /* MODULE */
388+
MODULE_DESCRIPTION("AMD LANCE/PCnet Ethernet driver");
388389
MODULE_LICENSE("GPL");
389390

390391

drivers/net/ethernet/amd/mvme147.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ static int m147lance_close(struct net_device *dev)
178178
return 0;
179179
}
180180

181+
MODULE_DESCRIPTION("MVME147 LANCE Ethernet driver");
181182
MODULE_LICENSE("GPL");
182183

183184
static struct net_device *dev_mvme147_lance;

drivers/net/ethernet/amd/sun3lance.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ static int lance_debug = 1;
7474
#endif
7575
module_param(lance_debug, int, 0);
7676
MODULE_PARM_DESC(lance_debug, "SUN3 Lance debug level (0-3)");
77+
MODULE_DESCRIPTION("Sun3/Sun3x on-board LANCE Ethernet driver");
7778
MODULE_LICENSE("GPL");
7879

7980
#define DPRINTK(n,a) \

0 commit comments

Comments
 (0)