Skip to content

Commit df37370

Browse files
ffainellidavem330
authored andcommitted
net: dsa: b53: Always use dev->vlan_enabled in b53_configure_vlan()
b53_configure_vlan() is called by the bcm_sf2 driver upon setup and indirectly through resume as well. During the initial setup, we are guaranteed that dev->vlan_enabled is false, so there is no change in behavior, however during suspend, we may have enabled VLANs before, so we do want to restore that setting. Fixes: dad8d7c ("net: dsa: b53: Properly account for VLAN filtering") Fixes: 967dd82 ("net: dsa: b53: Add support for Broadcom RoboSwitch") Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7d10f07 commit df37370

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ int b53_configure_vlan(struct dsa_switch *ds)
693693
b53_do_vlan_op(dev, VTA_CMD_CLEAR);
694694
}
695695

696-
b53_enable_vlan(dev, false, ds->vlan_filtering);
696+
b53_enable_vlan(dev, dev->vlan_enabled, ds->vlan_filtering);
697697

698698
b53_for_each_port(dev, i)
699699
b53_write16(dev, B53_VLAN_PAGE,

0 commit comments

Comments
 (0)