Skip to content

Commit df7dbcb

Browse files
jpirkodavem330
authored andcommitted
rtnetlink: put "BOND" into nl attribute names which are related to bonding
Signed-off-by: Jiri Pirko <[email protected]> Acked-by: Nicolas Dichtel <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0a9099f commit df7dbcb

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

drivers/net/bonding/bond_netlink.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,27 +26,27 @@ int bond_get_slave(struct net_device *slave_dev, struct sk_buff *skb)
2626
struct slave *slave = bond_slave_get_rtnl(slave_dev);
2727
const struct aggregator *agg;
2828

29-
if (nla_put_u8(skb, IFLA_SLAVE_STATE, bond_slave_state(slave)))
29+
if (nla_put_u8(skb, IFLA_BOND_SLAVE_STATE, bond_slave_state(slave)))
3030
goto nla_put_failure;
3131

32-
if (nla_put_u8(skb, IFLA_SLAVE_MII_STATUS, slave->link))
32+
if (nla_put_u8(skb, IFLA_BOND_SLAVE_MII_STATUS, slave->link))
3333
goto nla_put_failure;
3434

35-
if (nla_put_u32(skb, IFLA_SLAVE_LINK_FAILURE_COUNT,
35+
if (nla_put_u32(skb, IFLA_BOND_SLAVE_LINK_FAILURE_COUNT,
3636
slave->link_failure_count))
3737
goto nla_put_failure;
3838

39-
if (nla_put(skb, IFLA_SLAVE_PERM_HWADDR,
39+
if (nla_put(skb, IFLA_BOND_SLAVE_PERM_HWADDR,
4040
slave_dev->addr_len, slave->perm_hwaddr))
4141
goto nla_put_failure;
4242

43-
if (nla_put_u16(skb, IFLA_SLAVE_QUEUE_ID, slave->queue_id))
43+
if (nla_put_u16(skb, IFLA_BOND_SLAVE_QUEUE_ID, slave->queue_id))
4444
goto nla_put_failure;
4545

4646
if (slave->bond->params.mode == BOND_MODE_8023AD) {
4747
agg = SLAVE_AD_INFO(slave).port.aggregator;
4848
if (agg)
49-
if (nla_put_u16(skb, IFLA_SLAVE_AD_AGGREGATOR_ID,
49+
if (nla_put_u16(skb, IFLA_BOND_SLAVE_AD_AGGREGATOR_ID,
5050
agg->aggregator_identifier))
5151
goto nla_put_failure;
5252
}

include/uapi/linux/if_link.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ enum {
144144
IFLA_NUM_RX_QUEUES,
145145
IFLA_CARRIER,
146146
IFLA_PHYS_PORT_ID,
147-
IFLA_SLAVE,
147+
IFLA_BOND_SLAVE,
148148
__IFLA_MAX
149149
};
150150

@@ -370,16 +370,17 @@ enum {
370370
#define IFLA_BOND_AD_INFO_MAX (__IFLA_BOND_AD_INFO_MAX - 1)
371371

372372
enum {
373-
IFLA_SLAVE_STATE,
374-
IFLA_SLAVE_MII_STATUS,
375-
IFLA_SLAVE_LINK_FAILURE_COUNT,
376-
IFLA_SLAVE_PERM_HWADDR,
377-
IFLA_SLAVE_QUEUE_ID,
378-
IFLA_SLAVE_AD_AGGREGATOR_ID,
379-
__IFLA_SLAVE_MAX,
373+
IFLA_BOND_SLAVE_UNSPEC,
374+
IFLA_BOND_SLAVE_STATE,
375+
IFLA_BOND_SLAVE_MII_STATUS,
376+
IFLA_BOND_SLAVE_LINK_FAILURE_COUNT,
377+
IFLA_BOND_SLAVE_PERM_HWADDR,
378+
IFLA_BOND_SLAVE_QUEUE_ID,
379+
IFLA_BOND_SLAVE_AD_AGGREGATOR_ID,
380+
__IFLA_BOND_SLAVE_MAX,
380381
};
381382

382-
#define IFLA_SLAVE_MAX (__IFLA_SLAVE_MAX - 1)
383+
#define IFLA_BOND_SLAVE_MAX (__IFLA_BOND_SLAVE_MAX - 1)
383384

384385
/* SR-IOV virtual function management section */
385386

net/core/rtnetlink.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -725,13 +725,13 @@ static size_t rtnl_bond_slave_size(const struct net_device *dev)
725725
{
726726
struct net_device *bond;
727727
size_t slave_size =
728-
nla_total_size(sizeof(struct nlattr)) + /* IFLA_SLAVE */
729-
nla_total_size(1) + /* IFLA_SLAVE_STATE */
730-
nla_total_size(1) + /* IFLA_SLAVE_MII_STATUS */
731-
nla_total_size(4) + /* IFLA_SLAVE_LINK_FAILURE_COUNT */
732-
nla_total_size(MAX_ADDR_LEN) + /* IFLA_SLAVE_PERM_HWADDR */
733-
nla_total_size(2) + /* IFLA_SLAVE_QUEUE_ID */
734-
nla_total_size(2) + /* IFLA_SLAVE_AD_AGGREGATOR_ID */
728+
nla_total_size(sizeof(struct nlattr)) + /* IFLA_BOND_SLAVE */
729+
nla_total_size(1) + /* IFLA_BOND_SLAVE_STATE */
730+
nla_total_size(1) + /* IFLA_BOND_SLAVE_MII_STATUS */
731+
nla_total_size(4) + /* IFLA_BOND_SLAVE_LINK_FAILURE_COUNT */
732+
nla_total_size(MAX_ADDR_LEN) + /* IFLA_BOND_SLAVE_PERM_HWADDR */
733+
nla_total_size(2) + /* IFLA_BOND_SLAVE_QUEUE_ID */
734+
nla_total_size(2) + /* IFLA_BOND_SLAVE_AD_AGGREGATOR_ID */
735735
0;
736736

737737
if (netif_is_bond_slave((struct net_device *)dev)) {
@@ -883,7 +883,7 @@ static size_t rtnl_bond_slave_fill(struct sk_buff *skb, struct net_device *dev)
883883
if (!bond || !bond->netdev_ops->ndo_get_slave)
884884
return 0;
885885

886-
nest = nla_nest_start(skb, IFLA_SLAVE);
886+
nest = nla_nest_start(skb, IFLA_BOND_SLAVE);
887887
if (!nest)
888888
return -EMSGSIZE;
889889

0 commit comments

Comments
 (0)