Skip to content

Commit df8441c

Browse files
paravmellanoxjgunthorpe
authored andcommitted
IB/core: Avoid exporting module internal function
ib_security_modify_qp and ib_security_pkey_access are core internal function. So avoid exporting them. ib_security_pkey_access is used only when secuirty hooks are enabled so avoid defining it otherwise. Signed-off-by: Parav Pandit <[email protected]> Reviewed-by: Daniel Jurgens <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 56d0a7d commit df8441c

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

drivers/infiniband/core/core_priv.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -213,11 +213,6 @@ int ib_get_cached_subnet_prefix(struct ib_device *device,
213213
u64 *sn_pfx);
214214

215215
#ifdef CONFIG_SECURITY_INFINIBAND
216-
int ib_security_pkey_access(struct ib_device *dev,
217-
u8 port_num,
218-
u16 pkey_index,
219-
void *sec);
220-
221216
void ib_security_destroy_port_pkey_list(struct ib_device *device);
222217

223218
void ib_security_cache_change(struct ib_device *device,
@@ -240,14 +235,6 @@ int ib_mad_agent_security_setup(struct ib_mad_agent *agent,
240235
void ib_mad_agent_security_cleanup(struct ib_mad_agent *agent);
241236
int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index);
242237
#else
243-
static inline int ib_security_pkey_access(struct ib_device *dev,
244-
u8 port_num,
245-
u16 pkey_index,
246-
void *sec)
247-
{
248-
return 0;
249-
}
250-
251238
static inline void ib_security_destroy_port_pkey_list(struct ib_device *device)
252239
{
253240
}

drivers/infiniband/core/security.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -620,12 +620,11 @@ int ib_security_modify_qp(struct ib_qp *qp,
620620
}
621621
return ret;
622622
}
623-
EXPORT_SYMBOL(ib_security_modify_qp);
624623

625-
int ib_security_pkey_access(struct ib_device *dev,
626-
u8 port_num,
627-
u16 pkey_index,
628-
void *sec)
624+
static int ib_security_pkey_access(struct ib_device *dev,
625+
u8 port_num,
626+
u16 pkey_index,
627+
void *sec)
629628
{
630629
u64 subnet_prefix;
631630
u16 pkey;
@@ -642,7 +641,6 @@ int ib_security_pkey_access(struct ib_device *dev,
642641

643642
return security_ib_pkey_access(sec, subnet_prefix, pkey);
644643
}
645-
EXPORT_SYMBOL(ib_security_pkey_access);
646644

647645
static int ib_mad_agent_security_change(struct notifier_block *nb,
648646
unsigned long event,

0 commit comments

Comments
 (0)