Skip to content

Commit df95856

Browse files
committed
Merge branches 'acpi-tables' and 'acpica'
Merge ACPICA regression fix and a fix for the recently added PPTT support. * acpi-tables: ACPI / PPTT: use ACPI ID whenever ACPI_PPTT_ACPI_PROCESSOR_ID_VALID is set * acpica: ACPICA: Drop leading newlines from error messages
3 parents 673b427 + 3099803 + a0d5f3b commit df95856

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

drivers/acpi/acpica/uterror.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,19 +182,19 @@ acpi_ut_prefixed_namespace_error(const char *module_name,
182182
switch (lookup_status) {
183183
case AE_ALREADY_EXISTS:
184184

185-
acpi_os_printf("\n" ACPI_MSG_BIOS_ERROR);
185+
acpi_os_printf(ACPI_MSG_BIOS_ERROR);
186186
message = "Failure creating";
187187
break;
188188

189189
case AE_NOT_FOUND:
190190

191-
acpi_os_printf("\n" ACPI_MSG_BIOS_ERROR);
191+
acpi_os_printf(ACPI_MSG_BIOS_ERROR);
192192
message = "Could not resolve";
193193
break;
194194

195195
default:
196196

197-
acpi_os_printf("\n" ACPI_MSG_ERROR);
197+
acpi_os_printf(ACPI_MSG_ERROR);
198198
message = "Failure resolving";
199199
break;
200200
}

drivers/acpi/pptt.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,14 @@ static int topology_get_acpi_cpu_tag(struct acpi_table_header *table,
481481
if (cpu_node) {
482482
cpu_node = acpi_find_processor_package_id(table, cpu_node,
483483
level, flag);
484-
/* Only the first level has a guaranteed id */
485-
if (level == 0)
484+
/*
485+
* As per specification if the processor structure represents
486+
* an actual processor, then ACPI processor ID must be valid.
487+
* For processor containers ACPI_PPTT_ACPI_PROCESSOR_ID_VALID
488+
* should be set if the UID is valid
489+
*/
490+
if (level == 0 ||
491+
cpu_node->flags & ACPI_PPTT_ACPI_PROCESSOR_ID_VALID)
486492
return cpu_node->acpi_processor_id;
487493
return ACPI_PTR_DIFF(cpu_node, table);
488494
}

0 commit comments

Comments
 (0)