Skip to content

Commit dfd7aec

Browse files
committed
Merge tag 'drm-intel-fixes-2014-07-03' of git://anongit.freedesktop.org/drm-intel
Fixes for 3.16-rc3; most importantly Jesse brings back VGA he took away on a bunch of machines. Also a vblank fix for BDW and a power workaround fix for VLV. * tag 'drm-intel-fixes-2014-07-03' of git://anongit.freedesktop.org/drm-intel: drm/i915: Drop early VLV WA to fix Voltage not getting dropped to Vmin drm/i915: only apply crt_present check on VLV drm/i915: Wait for vblank after enabling the primary plane on BDW
2 parents 80e6e6b + 5549d25 commit dfd7aec

File tree

3 files changed

+42
-1
lines changed

3 files changed

+42
-1
lines changed

drivers/gpu/drm/i915/intel_display.c

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2087,6 +2087,7 @@ void intel_flush_primary_plane(struct drm_i915_private *dev_priv,
20872087
static void intel_enable_primary_hw_plane(struct drm_i915_private *dev_priv,
20882088
enum plane plane, enum pipe pipe)
20892089
{
2090+
struct drm_device *dev = dev_priv->dev;
20902091
struct intel_crtc *intel_crtc =
20912092
to_intel_crtc(dev_priv->pipe_to_crtc_mapping[pipe]);
20922093
int reg;
@@ -2106,6 +2107,14 @@ static void intel_enable_primary_hw_plane(struct drm_i915_private *dev_priv,
21062107

21072108
I915_WRITE(reg, val | DISPLAY_PLANE_ENABLE);
21082109
intel_flush_primary_plane(dev_priv, plane);
2110+
2111+
/*
2112+
* BDW signals flip done immediately if the plane
2113+
* is disabled, even if the plane enable is already
2114+
* armed to occur at the next vblank :(
2115+
*/
2116+
if (IS_BROADWELL(dev))
2117+
intel_wait_for_vblank(dev, intel_crtc->pipe);
21092118
}
21102119

21112120
/**
@@ -11088,6 +11097,22 @@ const char *intel_output_name(int output)
1108811097
return names[output];
1108911098
}
1109011099

11100+
static bool intel_crt_present(struct drm_device *dev)
11101+
{
11102+
struct drm_i915_private *dev_priv = dev->dev_private;
11103+
11104+
if (IS_ULT(dev))
11105+
return false;
11106+
11107+
if (IS_CHERRYVIEW(dev))
11108+
return false;
11109+
11110+
if (IS_VALLEYVIEW(dev) && !dev_priv->vbt.int_crt_support)
11111+
return false;
11112+
11113+
return true;
11114+
}
11115+
1109111116
static void intel_setup_outputs(struct drm_device *dev)
1109211117
{
1109311118
struct drm_i915_private *dev_priv = dev->dev_private;
@@ -11096,7 +11121,7 @@ static void intel_setup_outputs(struct drm_device *dev)
1109611121

1109711122
intel_lvds_init(dev);
1109811123

11099-
if (!IS_ULT(dev) && !IS_CHERRYVIEW(dev) && dev_priv->vbt.int_crt_support)
11124+
if (intel_crt_present(dev))
1110011125
intel_crt_init(dev);
1110111126

1110211127
if (HAS_DDI(dev)) {

drivers/gpu/drm/i915/intel_pm.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3209,6 +3209,14 @@ void gen6_set_rps(struct drm_device *dev, u8 val)
32093209
*/
32103210
static void vlv_set_rps_idle(struct drm_i915_private *dev_priv)
32113211
{
3212+
struct drm_device *dev = dev_priv->dev;
3213+
3214+
/* Latest VLV doesn't need to force the gfx clock */
3215+
if (dev->pdev->revision >= 0xd) {
3216+
valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
3217+
return;
3218+
}
3219+
32123220
/*
32133221
* When we are idle. Drop to min voltage state.
32143222
*/

drivers/gpu/drm/i915/intel_sprite.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,14 @@ intel_post_enable_primary(struct drm_crtc *crtc)
690690
struct drm_device *dev = crtc->dev;
691691
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
692692

693+
/*
694+
* BDW signals flip done immediately if the plane
695+
* is disabled, even if the plane enable is already
696+
* armed to occur at the next vblank :(
697+
*/
698+
if (IS_BROADWELL(dev))
699+
intel_wait_for_vblank(dev, intel_crtc->pipe);
700+
693701
/*
694702
* FIXME IPS should be fine as long as one plane is
695703
* enabled, but in practice it seems to have problems

0 commit comments

Comments
 (0)