Skip to content

Commit e181b1f

Browse files
committed
[media] rtl28xxu: properly initialize pdata
As complained by smatch: drivers/media/usb/dvb-usb-v2/rtl28xxu.c:1159 rtl2832u_tuner_attach() info: 'pdata' is not actually initialized (unreached code). Cc: Antti Palosaari <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent bda977b commit e181b1f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/media/usb/dvb-usb-v2/rtl28xxu.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,10 +1055,13 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap)
10551055
struct i2c_board_info info;
10561056
struct i2c_client *client;
10571057
struct v4l2_subdev *subdev = NULL;
1058+
struct platform_device *pdev;
1059+
struct rtl2832_sdr_platform_data pdata;
10581060

10591061
dev_dbg(&d->intf->dev, "\n");
10601062

10611063
memset(&info, 0, sizeof(struct i2c_board_info));
1064+
memset(&pdata, 0, sizeof(pdata));
10621065

10631066
switch (dev->tuner) {
10641067
case TUNER_RTL2832_FC0012:
@@ -1155,9 +1158,6 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap)
11551158

11561159
/* register SDR */
11571160
switch (dev->tuner) {
1158-
struct platform_device *pdev;
1159-
struct rtl2832_sdr_platform_data pdata = {};
1160-
11611161
case TUNER_RTL2832_FC0012:
11621162
case TUNER_RTL2832_FC0013:
11631163
case TUNER_RTL2832_E4000:

0 commit comments

Comments
 (0)