Skip to content

Commit e199fa7

Browse files
committed
media: davinci: get rid of lots of kernel-doc warnings
Driver build produce lots of warnings due to wrong kernel-doc markups: drivers/media/platform/davinci/vpbe.c:60: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_current_encoder_info' drivers/media/platform/davinci/vpbe.c:78: warning: Function parameter or member 'cfg' not described in 'vpbe_find_encoder_sd_index' drivers/media/platform/davinci/vpbe.c:78: warning: Function parameter or member 'index' not described in 'vpbe_find_encoder_sd_index' drivers/media/platform/davinci/vpbe.c:105: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_g_cropcap' drivers/media/platform/davinci/vpbe.c:105: warning: Function parameter or member 'cropcap' not described in 'vpbe_g_cropcap' drivers/media/platform/davinci/vpbe.c:127: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_enum_outputs' drivers/media/platform/davinci/vpbe.c:127: warning: Function parameter or member 'output' not described in 'vpbe_enum_outputs' drivers/media/platform/davinci/vpbe.c:221: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_set_output' drivers/media/platform/davinci/vpbe.c:221: warning: Function parameter or member 'index' not described in 'vpbe_set_output' drivers/media/platform/davinci/vpbe.c:316: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_get_output' drivers/media/platform/davinci/vpbe.c:328: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_s_dv_timings' drivers/media/platform/davinci/vpbe.c:328: warning: Function parameter or member 'dv_timings' not described in 'vpbe_s_dv_timings' drivers/media/platform/davinci/vpbe.c:380: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_g_dv_timings' drivers/media/platform/davinci/vpbe.c:380: warning: Function parameter or member 'dv_timings' not described in 'vpbe_g_dv_timings' drivers/media/platform/davinci/vpbe.c:405: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_enum_dv_timings' drivers/media/platform/davinci/vpbe.c:405: warning: Function parameter or member 'timings' not described in 'vpbe_enum_dv_timings' drivers/media/platform/davinci/vpbe.c:436: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_s_std' drivers/media/platform/davinci/vpbe.c:436: warning: Function parameter or member 'std_id' not described in 'vpbe_s_std' drivers/media/platform/davinci/vpbe.c:475: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_g_std' drivers/media/platform/davinci/vpbe.c:475: warning: Function parameter or member 'std_id' not described in 'vpbe_g_std' drivers/media/platform/davinci/vpbe.c:500: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_set_mode' drivers/media/platform/davinci/vpbe.c:500: warning: Function parameter or member 'mode_info' not described in 'vpbe_set_mode' drivers/media/platform/davinci/vpbe.c:585: warning: Function parameter or member 'dev' not described in 'vpbe_initialize' drivers/media/platform/davinci/vpbe.c:585: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_initialize' drivers/media/platform/davinci/vpbe.c:779: warning: Function parameter or member 'dev' not described in 'vpbe_deinitialize' drivers/media/platform/davinci/vpbe.c:779: warning: Function parameter or member 'vpbe_dev' not described in 'vpbe_deinitialize' drivers/media/platform/davinci/vpbe_osd.c:144: warning: Function parameter or member 'sd' not described in '_osd_dm6446_vid0_pingpong' drivers/media/platform/davinci/vpbe_osd.c:144: warning: Function parameter or member 'field_inversion' not described in '_osd_dm6446_vid0_pingpong' drivers/media/platform/davinci/vpbe_osd.c:144: warning: Function parameter or member 'fb_base_phys' not described in '_osd_dm6446_vid0_pingpong' drivers/media/platform/davinci/vpbe_osd.c:144: warning: Function parameter or member 'lconfig' not described in '_osd_dm6446_vid0_pingpong' drivers/media/platform/davinci/vpbe_osd.c:799: warning: Function parameter or member 'sd' not described in 'try_layer_config' drivers/media/platform/davinci/vpbe_osd.c:799: warning: Function parameter or member 'layer' not described in 'try_layer_config' drivers/media/platform/davinci/vpbe_osd.c:799: warning: Function parameter or member 'lconfig' not described in 'try_layer_config' drivers/media/platform/davinci/vpbe_display.c:578: warning: Function parameter or member 'disp_dev' not described in 'vpbe_try_format' drivers/media/platform/davinci/vpbe_display.c:578: warning: Function parameter or member 'pixfmt' not described in 'vpbe_try_format' drivers/media/platform/davinci/vpbe_display.c:578: warning: Function parameter or member 'check' not described in 'vpbe_try_format' drivers/media/platform/davinci/vpbe_display.c:943: warning: Function parameter or member 'file' not described in 'vpbe_display_s_std' drivers/media/platform/davinci/vpbe_display.c:943: warning: Function parameter or member 'priv' not described in 'vpbe_display_s_std' drivers/media/platform/davinci/vpbe_display.c:943: warning: Function parameter or member 'std_id' not described in 'vpbe_display_s_std' drivers/media/platform/davinci/vpbe_display.c:975: warning: Function parameter or member 'file' not described in 'vpbe_display_g_std' drivers/media/platform/davinci/vpbe_display.c:975: warning: Function parameter or member 'priv' not described in 'vpbe_display_g_std' drivers/media/platform/davinci/vpbe_display.c:975: warning: Function parameter or member 'std_id' not described in 'vpbe_display_g_std' drivers/media/platform/davinci/vpbe_display.c:998: warning: Function parameter or member 'file' not described in 'vpbe_display_enum_output' drivers/media/platform/davinci/vpbe_display.c:998: warning: Function parameter or member 'priv' not described in 'vpbe_display_enum_output' drivers/media/platform/davinci/vpbe_display.c:998: warning: Function parameter or member 'output' not described in 'vpbe_display_enum_output' drivers/media/platform/davinci/vpbe_display.c:1025: warning: Function parameter or member 'file' not described in 'vpbe_display_s_output' drivers/media/platform/davinci/vpbe_display.c:1025: warning: Function parameter or member 'priv' not described in 'vpbe_display_s_output' drivers/media/platform/davinci/vpbe_display.c:1025: warning: Function parameter or member 'i' not described in 'vpbe_display_s_output' drivers/media/platform/davinci/vpbe_display.c:1054: warning: Function parameter or member 'file' not described in 'vpbe_display_g_output' drivers/media/platform/davinci/vpbe_display.c:1054: warning: Function parameter or member 'priv' not described in 'vpbe_display_g_output' drivers/media/platform/davinci/vpbe_display.c:1054: warning: Function parameter or member 'i' not described in 'vpbe_display_g_output' drivers/media/platform/davinci/vpbe_display.c:1074: warning: Function parameter or member 'file' not described in 'vpbe_display_enum_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1074: warning: Function parameter or member 'priv' not described in 'vpbe_display_enum_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1074: warning: Function parameter or member 'timings' not described in 'vpbe_display_enum_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1104: warning: Function parameter or member 'file' not described in 'vpbe_display_s_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1104: warning: Function parameter or member 'priv' not described in 'vpbe_display_s_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1104: warning: Function parameter or member 'timings' not described in 'vpbe_display_s_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1137: warning: Function parameter or member 'file' not described in 'vpbe_display_g_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1137: warning: Function parameter or member 'priv' not described in 'vpbe_display_g_dv_timings' drivers/media/platform/davinci/vpbe_display.c:1137: warning: Function parameter or member 'dv_timings' not described in 'vpbe_display_g_dv_timings' Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 79eab28 commit e199fa7

File tree

3 files changed

+36
-34
lines changed

3 files changed

+36
-34
lines changed

drivers/media/platform/davinci/vpbe.c

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ MODULE_AUTHOR("Texas Instruments");
5151

5252
/**
5353
* vpbe_current_encoder_info - Get config info for current encoder
54-
* @vpbe_dev - vpbe device ptr
54+
* @vpbe_dev: vpbe device ptr
5555
*
5656
* Return ptr to current encoder config info
5757
*/
@@ -68,8 +68,8 @@ vpbe_current_encoder_info(struct vpbe_device *vpbe_dev)
6868
/**
6969
* vpbe_find_encoder_sd_index - Given a name find encoder sd index
7070
*
71-
* @vpbe_config - ptr to vpbe cfg
72-
* @output_index - index used by application
71+
* @cfg: ptr to vpbe cfg
72+
* @index: index used by application
7373
*
7474
* Return sd index of the encoder
7575
*/
@@ -94,8 +94,8 @@ static int vpbe_find_encoder_sd_index(struct vpbe_config *cfg,
9494

9595
/**
9696
* vpbe_g_cropcap - Get crop capabilities of the display
97-
* @vpbe_dev - vpbe device ptr
98-
* @cropcap - cropcap is a ptr to struct v4l2_cropcap
97+
* @vpbe_dev: vpbe device ptr
98+
* @cropcap: cropcap is a ptr to struct v4l2_cropcap
9999
*
100100
* Update the crop capabilities in crop cap for current
101101
* mode
@@ -116,8 +116,8 @@ static int vpbe_g_cropcap(struct vpbe_device *vpbe_dev,
116116

117117
/**
118118
* vpbe_enum_outputs - enumerate outputs
119-
* @vpbe_dev - vpbe device ptr
120-
* @output - ptr to v4l2_output structure
119+
* @vpbe_dev: vpbe device ptr
120+
* @output: ptr to v4l2_output structure
121121
*
122122
* Enumerates the outputs available at the vpbe display
123123
* returns the status, -EINVAL if end of output list
@@ -212,8 +212,8 @@ static int vpbe_get_std_info_by_name(struct vpbe_device *vpbe_dev,
212212

213213
/**
214214
* vpbe_set_output - Set output
215-
* @vpbe_dev - vpbe device ptr
216-
* @index - index of output
215+
* @vpbe_dev: vpbe device ptr
216+
* @index: index of output
217217
*
218218
* Set vpbe output to the output specified by the index
219219
*/
@@ -308,7 +308,7 @@ static int vpbe_set_default_output(struct vpbe_device *vpbe_dev)
308308

309309
/**
310310
* vpbe_get_output - Get output
311-
* @vpbe_dev - vpbe device ptr
311+
* @vpbe_dev: vpbe device ptr
312312
*
313313
* return current vpbe output to the the index
314314
*/
@@ -317,7 +317,7 @@ static unsigned int vpbe_get_output(struct vpbe_device *vpbe_dev)
317317
return vpbe_dev->current_out_index;
318318
}
319319

320-
/**
320+
/*
321321
* vpbe_s_dv_timings - Set the given preset timings in the encoder
322322
*
323323
* Sets the timings if supported by the current encoder. Return the status.
@@ -369,7 +369,7 @@ static int vpbe_s_dv_timings(struct vpbe_device *vpbe_dev,
369369
return ret;
370370
}
371371

372-
/**
372+
/*
373373
* vpbe_g_dv_timings - Get the timings in the current encoder
374374
*
375375
* Get the timings in the current encoder. Return the status. 0 - success
@@ -394,7 +394,7 @@ static int vpbe_g_dv_timings(struct vpbe_device *vpbe_dev,
394394
return -EINVAL;
395395
}
396396

397-
/**
397+
/*
398398
* vpbe_enum_dv_timings - Enumerate the dv timings in the current encoder
399399
*
400400
* Get the timings in the current encoder. Return the status. 0 - success
@@ -426,7 +426,7 @@ static int vpbe_enum_dv_timings(struct vpbe_device *vpbe_dev,
426426
return 0;
427427
}
428428

429-
/**
429+
/*
430430
* vpbe_s_std - Set the given standard in the encoder
431431
*
432432
* Sets the standard if supported by the current encoder. Return the status.
@@ -465,7 +465,7 @@ static int vpbe_s_std(struct vpbe_device *vpbe_dev, v4l2_std_id std_id)
465465
return ret;
466466
}
467467

468-
/**
468+
/*
469469
* vpbe_g_std - Get the standard in the current encoder
470470
*
471471
* Get the standard in the current encoder. Return the status. 0 - success
@@ -488,7 +488,7 @@ static int vpbe_g_std(struct vpbe_device *vpbe_dev, v4l2_std_id *std_id)
488488
return -EINVAL;
489489
}
490490

491-
/**
491+
/*
492492
* vpbe_set_mode - Set mode in the current encoder using mode info
493493
*
494494
* Use the mode string to decide what timings to set in the encoder
@@ -572,7 +572,8 @@ static int platform_device_get(struct device *dev, void *data)
572572

573573
/**
574574
* vpbe_initialize() - Initialize the vpbe display controller
575-
* @vpbe_dev - vpbe device ptr
575+
* @dev: Master and slave device ptr
576+
* @vpbe_dev: vpbe device ptr
576577
*
577578
* Master frame buffer device drivers calls this to initialize vpbe
578579
* display controller. This will then registers v4l2 device and the sub
@@ -769,7 +770,8 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
769770

770771
/**
771772
* vpbe_deinitialize() - de-initialize the vpbe display controller
772-
* @dev - Master and slave device ptr
773+
* @dev: Master and slave device ptr
774+
* @vpbe_dev: vpbe device ptr
773775
*
774776
* vpbe_master and slave frame buffer devices calls this to de-initialize
775777
* the display controller. It is called when master and slave device

drivers/media/platform/davinci/vpbe_display.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ static void vpbe_disp_check_window_params(struct vpbe_display *disp_dev,
567567

568568
}
569569

570-
/**
570+
/*
571571
* vpbe_try_format()
572572
* If user application provides width and height, and have bytesperline set
573573
* to zero, driver calculates bytesperline and sizeimage based on hardware
@@ -932,7 +932,7 @@ static int vpbe_display_try_fmt(struct file *file, void *priv,
932932

933933
}
934934

935-
/**
935+
/*
936936
* vpbe_display_s_std - Set the given standard in the encoder
937937
*
938938
* Sets the standard if supported by the current encoder. Return the status.
@@ -964,7 +964,7 @@ static int vpbe_display_s_std(struct file *file, void *priv,
964964
return 0;
965965
}
966966

967-
/**
967+
/*
968968
* vpbe_display_g_std - Get the standard in the current encoder
969969
*
970970
* Get the standard in the current encoder. Return the status. 0 - success
@@ -987,7 +987,7 @@ static int vpbe_display_g_std(struct file *file, void *priv,
987987
return -EINVAL;
988988
}
989989

990-
/**
990+
/*
991991
* vpbe_display_enum_output - enumerate outputs
992992
*
993993
* Enumerates the outputs available at the vpbe display
@@ -1016,7 +1016,7 @@ static int vpbe_display_enum_output(struct file *file, void *priv,
10161016
return 0;
10171017
}
10181018

1019-
/**
1019+
/*
10201020
* vpbe_display_s_output - Set output to
10211021
* the output specified by the index
10221022
*/
@@ -1045,7 +1045,7 @@ static int vpbe_display_s_output(struct file *file, void *priv,
10451045
return 0;
10461046
}
10471047

1048-
/**
1048+
/*
10491049
* vpbe_display_g_output - Get output from subdevice
10501050
* for a given by the index
10511051
*/
@@ -1062,7 +1062,7 @@ static int vpbe_display_g_output(struct file *file, void *priv,
10621062
return 0;
10631063
}
10641064

1065-
/**
1065+
/*
10661066
* vpbe_display_enum_dv_timings - Enumerate the dv timings
10671067
*
10681068
* enum the timings in the current encoder. Return the status. 0 - success
@@ -1092,7 +1092,7 @@ vpbe_display_enum_dv_timings(struct file *file, void *priv,
10921092
return 0;
10931093
}
10941094

1095-
/**
1095+
/*
10961096
* vpbe_display_s_dv_timings - Set the dv timings
10971097
*
10981098
* Set the timings in the current encoder. Return the status. 0 - success
@@ -1125,7 +1125,7 @@ vpbe_display_s_dv_timings(struct file *file, void *priv,
11251125
return 0;
11261126
}
11271127

1128-
/**
1128+
/*
11291129
* vpbe_display_g_dv_timings - Set the dv timings
11301130
*
11311131
* Get the timings in the current encoder. Return the status. 0 - success

drivers/media/platform/davinci/vpbe_osd.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ static inline u32 osd_modify(struct osd_state *sd, u32 mask, u32 val,
124124

125125
/**
126126
* _osd_dm6446_vid0_pingpong() - field inversion fix for DM6446
127-
* @sd - ptr to struct osd_state
128-
* @field_inversion - inversion flag
129-
* @fb_base_phys - frame buffer address
130-
* @lconfig - ptr to layer config
127+
* @sd: ptr to struct osd_state
128+
* @field_inversion: inversion flag
129+
* @fb_base_phys: frame buffer address
130+
* @lconfig: ptr to layer config
131131
*
132132
* This routine implements a workaround for the field signal inversion silicon
133133
* erratum described in Advisory 1.3.8 for the DM6446. The fb_base_phys and
@@ -784,9 +784,9 @@ static void osd_get_layer_config(struct osd_state *sd, enum osd_layer layer,
784784

785785
/**
786786
* try_layer_config() - Try a specific configuration for the layer
787-
* @sd - ptr to struct osd_state
788-
* @layer - layer to configure
789-
* @lconfig - layer configuration to try
787+
* @sd: ptr to struct osd_state
788+
* @layer: layer to configure
789+
* @lconfig: layer configuration to try
790790
*
791791
* If the requested lconfig is completely rejected and the value of lconfig on
792792
* exit is the current lconfig, then try_layer_config() returns 1. Otherwise,

0 commit comments

Comments
 (0)