Skip to content

Commit e292dca

Browse files
Mahesh Bandewardavem330
authored andcommitted
bonding: avoid printing while holding a spinlock
Signed-off-by: Mahesh Bandewar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b5bf0f5 commit e292dca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/bonding/bond_3ad.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2446,9 +2446,9 @@ void bond_3ad_adapter_speed_duplex_changed(struct slave *slave)
24462446

24472447
spin_lock_bh(&slave->bond->mode_lock);
24482448
ad_update_actor_keys(port, false);
2449+
spin_unlock_bh(&slave->bond->mode_lock);
24492450
netdev_dbg(slave->bond->dev, "Port %d slave %s changed speed/duplex\n",
24502451
port->actor_port_number, slave->dev->name);
2451-
spin_unlock_bh(&slave->bond->mode_lock);
24522452
}
24532453

24542454
/**
@@ -2492,12 +2492,12 @@ void bond_3ad_handle_link_change(struct slave *slave, char link)
24922492
agg = __get_first_agg(port);
24932493
ad_agg_selection_logic(agg, &dummy);
24942494

2495+
spin_unlock_bh(&slave->bond->mode_lock);
2496+
24952497
netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n",
24962498
port->actor_port_number,
24972499
link == BOND_LINK_UP ? "UP" : "DOWN");
24982500

2499-
spin_unlock_bh(&slave->bond->mode_lock);
2500-
25012501
/* RTNL is held and mode_lock is released so it's safe
25022502
* to update slave_array here.
25032503
*/

0 commit comments

Comments
 (0)