net/mlx5: Better return types for CQE API

Tariq Toukan · Saeed Mahameed · commit e2abdcf1d2dd · 2018-07-18T14:33:25.000-07:00
Reduce sizes of return types.
Use bool for binary indication.

Signed-off-by: Tariq Toukan &lt;tariqt@mellanox.com&gt;
Signed-off-by: Saeed Mahameed &lt;saeedm@mellanox.com&gt;
diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/device.h
@@ -750,7 +750,7 @@ enum {
 
 #define MLX5_MINI_CQE_ARRAY_SIZE 8
 
-static inline int mlx5_get_cqe_format(struct mlx5_cqe64 *cqe)
+static inline u8 mlx5_get_cqe_format(struct mlx5_cqe64 *cqe)
 {
 	return (cqe->op_own >> 2) & 0x3;
 }
@@ -770,14 +770,14 @@ static inline u8 get_cqe_l3_hdr_type(struct mlx5_cqe64 *cqe)
 	return (cqe->l4_l3_hdr_type >> 2) & 0x3;
 }
 
-static inline u8 cqe_is_tunneled(struct mlx5_cqe64 *cqe)
+static inline bool cqe_is_tunneled(struct mlx5_cqe64 *cqe)
 {
 	return cqe->outer_l3_tunneled & 0x1;
 }
 
-static inline int cqe_has_vlan(struct mlx5_cqe64 *cqe)
+static inline bool cqe_has_vlan(struct mlx5_cqe64 *cqe)
 {
-	return !!(cqe->l4_l3_hdr_type & 0x1);
+	return cqe->l4_l3_hdr_type & 0x1;
 }
 
 static inline u64 get_cqe_ts(struct mlx5_cqe64 *cqe)

Original file line number	Diff line number	Diff line change
`@@ -750,7 +750,7 @@ enum {`
`750`	`750`
`751`	`751`	`#define MLX5_MINI_CQE_ARRAY_SIZE 8`
`752`	`752`
`753`		`-static inline int mlx5_get_cqe_format(struct mlx5_cqe64 *cqe)`
	`753`	`+static inline u8 mlx5_get_cqe_format(struct mlx5_cqe64 *cqe)`
`754`	`754`	`{`
`755`	`755`	`return (cqe->op_own >> 2) & 0x3;`
`756`	`756`	`}`
`@@ -770,14 +770,14 @@ static inline u8 get_cqe_l3_hdr_type(struct mlx5_cqe64 *cqe)`
`770`	`770`	`return (cqe->l4_l3_hdr_type >> 2) & 0x3;`
`771`	`771`	`}`
`772`	`772`
`773`		`-static inline u8 cqe_is_tunneled(struct mlx5_cqe64 *cqe)`
	`773`	`+static inline bool cqe_is_tunneled(struct mlx5_cqe64 *cqe)`
`774`	`774`	`{`
`775`	`775`	`return cqe->outer_l3_tunneled & 0x1;`
`776`	`776`	`}`
`777`	`777`
`778`		`-static inline int cqe_has_vlan(struct mlx5_cqe64 *cqe)`
	`778`	`+static inline bool cqe_has_vlan(struct mlx5_cqe64 *cqe)`
`779`	`779`	`{`
`780`		`- return !!(cqe->l4_l3_hdr_type & 0x1);`
	`780`	`+ return cqe->l4_l3_hdr_type & 0x1;`
`781`	`781`	`}`
`782`	`782`
`783`	`783`	`static inline u64 get_cqe_ts(struct mlx5_cqe64 *cqe)`