Skip to content

Commit e2d8f64

Browse files
Rafał Miłeckidavem330
authored andcommitted
net: bgmac: make it clear when setting interface type to RMII
It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is equal to 0. It make code a bit clener, so far when reading it one could think we forgot to set a proper mode. It also keeps this mode code in sync with other ones. Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1cb94db commit e2d8f64

File tree

1 file changed

+2
-1
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+2
-1
lines changed

drivers/net/ethernet/broadcom/bgmac.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,8 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
932932
et_swtype <<= 4;
933933
sw_type = et_swtype;
934934
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_EPHYRMII) {
935-
sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
935+
sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RMII |
936+
BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
936937
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_RGMII) {
937938
sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
938939
BGMAC_CHIPCTL_1_SW_TYPE_RGMII;

0 commit comments

Comments
 (0)