Skip to content

Commit e45a618

Browse files
david decotignydavem330
authored andcommitted
forcedeth: fix a few sparse warnings (variable shadowing)
This fixes the following sparse warnings: drivers/net/ethernet/nvidia/forcedeth.c:2113:7: warning: symbol 'size' shadows an earlier one drivers/net/ethernet/nvidia/forcedeth.c:2102:6: originally declared here drivers/net/ethernet/nvidia/forcedeth.c:2155:7: warning: symbol 'size' shadows an earlier one drivers/net/ethernet/nvidia/forcedeth.c:2102:6: originally declared here drivers/net/ethernet/nvidia/forcedeth.c:2227:7: warning: symbol 'size' shadows an earlier one drivers/net/ethernet/nvidia/forcedeth.c:2215:6: originally declared here drivers/net/ethernet/nvidia/forcedeth.c:2271:7: warning: symbol 'size' shadows an earlier one drivers/net/ethernet/nvidia/forcedeth.c:2215:6: originally declared here drivers/net/ethernet/nvidia/forcedeth.c:2986:20: warning: symbol 'addr' shadows an earlier one drivers/net/ethernet/nvidia/forcedeth.c:2963:6: originally declared here Signed-off-by: David Decotigny <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0bdfea8 commit e45a618

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

drivers/net/ethernet/nvidia/forcedeth.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2103,10 +2103,10 @@ static netdev_tx_t nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
21032103

21042104
/* add fragments to entries count */
21052105
for (i = 0; i < fragments; i++) {
2106-
u32 size = skb_frag_size(&skb_shinfo(skb)->frags[i]);
2106+
u32 frag_size = skb_frag_size(&skb_shinfo(skb)->frags[i]);
21072107

2108-
entries += (size >> NV_TX2_TSO_MAX_SHIFT) +
2109-
((size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
2108+
entries += (frag_size >> NV_TX2_TSO_MAX_SHIFT) +
2109+
((frag_size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
21102110
}
21112111

21122112
spin_lock_irqsave(&np->lock, flags);
@@ -2145,13 +2145,13 @@ static netdev_tx_t nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
21452145
/* setup the fragments */
21462146
for (i = 0; i < fragments; i++) {
21472147
const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
2148-
u32 size = skb_frag_size(frag);
2148+
u32 frag_size = skb_frag_size(frag);
21492149
offset = 0;
21502150

21512151
do {
21522152
prev_tx = put_tx;
21532153
prev_tx_ctx = np->put_tx_ctx;
2154-
bcnt = (size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : size;
2154+
bcnt = (frag_size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : frag_size;
21552155
np->put_tx_ctx->dma = skb_frag_dma_map(
21562156
&np->pci_dev->dev,
21572157
frag, offset,
@@ -2163,12 +2163,12 @@ static netdev_tx_t nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
21632163
put_tx->flaglen = cpu_to_le32((bcnt-1) | tx_flags);
21642164

21652165
offset += bcnt;
2166-
size -= bcnt;
2166+
frag_size -= bcnt;
21672167
if (unlikely(put_tx++ == np->last_tx.orig))
21682168
put_tx = np->first_tx.orig;
21692169
if (unlikely(np->put_tx_ctx++ == np->last_tx_ctx))
21702170
np->put_tx_ctx = np->first_tx_ctx;
2171-
} while (size);
2171+
} while (frag_size);
21722172
}
21732173

21742174
/* set last fragment flag */
@@ -2217,10 +2217,10 @@ static netdev_tx_t nv_start_xmit_optimized(struct sk_buff *skb,
22172217

22182218
/* add fragments to entries count */
22192219
for (i = 0; i < fragments; i++) {
2220-
u32 size = skb_frag_size(&skb_shinfo(skb)->frags[i]);
2220+
u32 frag_size = skb_frag_size(&skb_shinfo(skb)->frags[i]);
22212221

2222-
entries += (size >> NV_TX2_TSO_MAX_SHIFT) +
2223-
((size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
2222+
entries += (frag_size >> NV_TX2_TSO_MAX_SHIFT) +
2223+
((frag_size & (NV_TX2_TSO_MAX_SIZE-1)) ? 1 : 0);
22242224
}
22252225

22262226
spin_lock_irqsave(&np->lock, flags);
@@ -2261,13 +2261,13 @@ static netdev_tx_t nv_start_xmit_optimized(struct sk_buff *skb,
22612261
/* setup the fragments */
22622262
for (i = 0; i < fragments; i++) {
22632263
skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
2264-
u32 size = skb_frag_size(frag);
2264+
u32 frag_size = skb_frag_size(frag);
22652265
offset = 0;
22662266

22672267
do {
22682268
prev_tx = put_tx;
22692269
prev_tx_ctx = np->put_tx_ctx;
2270-
bcnt = (size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : size;
2270+
bcnt = (frag_size > NV_TX2_TSO_MAX_SIZE) ? NV_TX2_TSO_MAX_SIZE : frag_size;
22712271
np->put_tx_ctx->dma = skb_frag_dma_map(
22722272
&np->pci_dev->dev,
22732273
frag, offset,
@@ -2280,12 +2280,12 @@ static netdev_tx_t nv_start_xmit_optimized(struct sk_buff *skb,
22802280
put_tx->flaglen = cpu_to_le32((bcnt-1) | tx_flags);
22812281

22822282
offset += bcnt;
2283-
size -= bcnt;
2283+
frag_size -= bcnt;
22842284
if (unlikely(put_tx++ == np->last_tx.ex))
22852285
put_tx = np->first_tx.ex;
22862286
if (unlikely(np->put_tx_ctx++ == np->last_tx_ctx))
22872287
np->put_tx_ctx = np->first_tx_ctx;
2288-
} while (size);
2288+
} while (frag_size);
22892289
}
22902290

22912291
/* set last fragment flag */
@@ -2933,11 +2933,11 @@ static void nv_set_multicast(struct net_device *dev)
29332933
struct netdev_hw_addr *ha;
29342934

29352935
netdev_for_each_mc_addr(ha, dev) {
2936-
unsigned char *addr = ha->addr;
2936+
unsigned char *hw_addr = ha->addr;
29372937
u32 a, b;
29382938

2939-
a = le32_to_cpu(*(__le32 *) addr);
2940-
b = le16_to_cpu(*(__le16 *) (&addr[4]));
2939+
a = le32_to_cpu(*(__le32 *) hw_addr);
2940+
b = le16_to_cpu(*(__le16 *) (&hw_addr[4]));
29412941
alwaysOn[0] &= a;
29422942
alwaysOff[0] &= ~a;
29432943
alwaysOn[1] &= b;

0 commit comments

Comments
 (0)